Skip to content

Commit 510c8a6

Browse files
authored
Merge pull request #56 from knz/20201106-downgrade-gogoproto
deps: downgrade to gogoproto 1.2
2 parents b41978a + 6d8d14a commit 510c8a6

File tree

13 files changed

+3010
-6920
lines changed

13 files changed

+3010
-6920
lines changed

Makefile.update-protos

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,23 @@
55
# go get github.com/cockroachdb/protoc-gen-gogoroach
66
# go get github.com/gogo/protobuf/types
77
# go get github.com/gogo/protobuf/protoc-gen-gogo
8+
#
9+
# Note: as of 2020-11-01, it is not (yet) possible to use gogoproto
10+
# v1.3.x to generate .pb.go files so that they are compatible with
11+
# CockroachDB. This is because CockroachDB hardcodes gogoproto at
12+
# version v1.2, and thus does not provide v1.3's
13+
# proto.GoGoProtoPackageIsVersion3.
14+
#
15+
# For details, see https://github.com/cockroachdb/cockroach/issues/56378
16+
#
17+
# Until this is resolved, the "go get" commands above are not
18+
# adequate; instead:
19+
#
20+
# 1. set the PATH env var to point to CockroachDB's `bin`
21+
# sub-directory (after a successful CockroachDB build), where a
22+
# suitable version of protoc-gen-gogoroach is provided.
23+
#
24+
# 2. run `make -f Makefile.update-protos` with this PATH active.
825

926
PROTOS := $(wildcard errorspb/*.proto)
1027
GO_SOURCES = $(PROTOS:.proto=.pb.go)

0 commit comments

Comments
 (0)