Skip to content

Commit 72ec752

Browse files
authored
Merge pull request #67 from knz/20210413-proto
Update to gogoproto 1.3.
2 parents 7c0cd41 + 51b9383 commit 72ec752

File tree

11 files changed

+1066
-1157
lines changed

11 files changed

+1066
-1157
lines changed

Makefile.update-protos

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,16 @@
66
# go get github.com/gogo/protobuf/types
77
# go get github.com/gogo/protobuf/protoc-gen-gogo
88
#
9-
# Note: as of 2020-11-01, it is not (yet) possible to use gogoproto
10-
# v1.3.x to generate .pb.go files so that they are compatible with
11-
# CockroachDB. This is because CockroachDB hardcodes gogoproto at
12-
# version v1.2, and thus does not provide v1.3's
13-
# proto.GoGoProtoPackageIsVersion3.
9+
# Note: as of 2021-04-13, we like to use a custom protoc-gen-gogo
10+
# with additional options, to stabilize the marshalled
11+
# encoding of objects (so that they are deterministic
12+
# across marshal/unmarshal cycles) and reduce the memory footprint
13+
# of objects:
1414
#
15-
# For details, see https://github.com/cockroachdb/cockroach/issues/56378
15+
# vanity.TurnOnStable_MarshalerAll,
16+
# vanity.TurnOffGoUnrecognizedAll,
17+
# vanity.TurnOffGoUnkeyedAll,
18+
# vanity.TurnOffGoSizecacheAll,
1619
#
1720
# Until this is resolved, the "go get" commands above are not
1821
# adequate; instead:

errbase/internal/unknown.pb.go

Lines changed: 62 additions & 81 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)