Skip to content

Commit 51d7d68

Browse files
authored
Merge pull request #106 from rafiss/activerecord-19.1
Skip Activerecord tests for <=v19.1 These are failing currently because of missing pg_catalog tables. We'll skip the test for versions <=19.1 until we can debug the underlying issue. (Note, we may decide to leave the skipped test permanently, as our tooling support page specifies that we support ActiveRecord for CockroachDB 20.1+.)
2 parents 1820bac + 7a9cae5 commit 51d7d68

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

testing/main_test.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,10 +157,14 @@ func testORM(
157157
db, dbURL, version, stopDB := initTestDatabase(t, app)
158158
defer stopDB()
159159

160-
if orm == "django" && (strings.HasPrefix(version, "v2.0") || strings.HasPrefix(version, "v2.1")) {
160+
if orm == "django" && (strings.HasPrefix(version, "v2.0") || strings.HasPrefix(version, "v2.1")) {
161161
t.Skip("TestDjango fails on CRDB <=v2.1 due to missing foreign key support.")
162162
}
163163

164+
if orm == "activerecord" && (strings.HasPrefix(version, "v2.") || strings.HasPrefix(version, "v19.1")) {
165+
t.Skip("TestActiveRecord fails on CRDB <=v19.1 due to missing pg_catalog support.")
166+
}
167+
164168
td := testDriver{
165169
db: db,
166170
dbName: app.dbName(),

0 commit comments

Comments
 (0)