Skip to content

Commit e020d76

Browse files
authored
Merge pull request #143 from rafiss/skip-tenant-21.1
Skip multi-tenant tests for 21.1
2 parents 74f3ef9 + 61fb879 commit e020d76

File tree

3 files changed

+6
-28
lines changed

3 files changed

+6
-28
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ module github.com/cockroachdb/examples-orms
33
go 1.13
44

55
require (
6-
github.com/cockroachdb/cockroach-go/v2 v2.2.3
6+
github.com/cockroachdb/cockroach-go/v2 v2.2.4
77
github.com/go-pg/pg/v10 v10.9.0
88
github.com/julienschmidt/httprouter v1.1.0
99
github.com/lib/pq v1.10.0

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ github.com/census-instrumentation/opencensus-proto v0.2.1/go.mod h1:f6KPmirojxKA
44
github.com/client9/misspell v0.3.4/go.mod h1:qj6jICC3Q7zFZvVWo7KLAzC3yx5G7kyvSDkc90ppPyw=
55
github.com/cockroachdb/apd v1.1.0 h1:3LFP3629v+1aKXU5Q37mxmRxX/pIu1nijXydLShEq5I=
66
github.com/cockroachdb/apd v1.1.0/go.mod h1:8Sl8LxpKi29FqWXR16WEFZRNSz3SoPzUzeMeY4+DwBQ=
7-
github.com/cockroachdb/cockroach-go/v2 v2.2.3 h1:2881elKwTMrAWuSP2N/4PtU6XyqoyI55Fv3TSTD+Efo=
8-
github.com/cockroachdb/cockroach-go/v2 v2.2.3/go.mod h1:u3MiKYGupPPjkn3ozknpMUpxPaNLTFWAya419/zv6eI=
7+
github.com/cockroachdb/cockroach-go/v2 v2.2.4 h1:VuiBJKut2Imgrzl+TNk+U5+GxLOh3hnIFxU0EzjTCnI=
8+
github.com/cockroachdb/cockroach-go/v2 v2.2.4/go.mod h1:u3MiKYGupPPjkn3ozknpMUpxPaNLTFWAya419/zv6eI=
99
github.com/coreos/go-systemd v0.0.0-20190321100706-95778dfbb74e/go.mod h1:F5haX7vjVVG0kc13fIWeqUViNPyEJxv/OmvnBo0Yme4=
1010
github.com/coreos/go-systemd v0.0.0-20190719114852-fd7a80b32e1f/go.mod h1:F5haX7vjVVG0kc13fIWeqUViNPyEJxv/OmvnBo0Yme4=
1111
github.com/creack/pty v1.1.7/go.mod h1:lj5s0c3V2DBrqTV7llrYr5NG6My20zk30Fl46Y7DoTY=

testing/main_test.go

Lines changed: 3 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -269,31 +269,9 @@ func testORM(t *testing.T, info testInfo, auth authMode) {
269269
},
270270
}
271271

272-
// This cockroach version supports creating tenants, add a test case to
273-
// run a tenant server. We need at least 20.1-18 for everything to work out
274-
// as the certificate story was reworked immediately before that version
275-
// was minted.
276-
var tenantsSupported bool
277-
if err := db.QueryRow(`
278-
SELECT
279-
(major = 20 AND minor = 1 AND (unstable IS NOT NULL AND unstable > 17))
280-
OR (major = 20 AND minor > 1)
281-
OR (major > 20)
282-
FROM
283-
[
284-
SELECT
285-
regexp_extract(v, e'^(\\d+)\\.')::INT8 AS major,
286-
regexp_extract(v, e'^\\d+\\.(\\d+)')::INT8
287-
AS minor,
288-
regexp_extract(v, e'^\\d+\\.\\d+-(\\d+)')::INT8
289-
AS unstable
290-
FROM
291-
[SHOW CLUSTER SETTING version] AS t (v)
292-
];
293-
`,
294-
).Scan(&tenantsSupported); err != nil {
295-
t.Fatalf("unable to read cluster version: %s", err)
296-
}
272+
// If the cockroach version supports creating tenants, add a test case to
273+
// run a tenant server. We need at least v21.2 for everything to work.
274+
tenantsSupported := crdbVersion.AtLeast(version.MustParse("v21.2.0-alpha"))
297275
if tenantsSupported {
298276
// Connect to the tenant through the SQL proxy, which is only supported
299277
// when using secure+password auth. (The proxy does not support client

0 commit comments

Comments
 (0)