fix golangci-lint

Author: otan

go/gopg/server.go

@@ -316,15 +316,15 @@ func (s *Server) addProductToOrder(w http.ResponseWriter, r *http.Request, ps ht
 		ID: orderID,
 	}
 	if err := s.db.Model(&order).Select(); err != nil {
-		tx.Rollback()
+		_ = tx.Rollback()
 		http.Error(w, err.Error(), errToStatusCode(err))
 		return
 	}
 
 	const productIDParam = "productID"
 	productIDString := r.URL.Query().Get(productIDParam)
 	if productIDString == "" {
-		tx.Rollback()
+		_ = tx.Rollback()
 		writeMissingParamError(w, productIDParam)
 		return
 	}
@@ -337,14 +337,14 @@ func (s *Server) addProductToOrder(w http.ResponseWriter, r *http.Request, ps ht
 		ID: productID,
 	}
 	if err := s.db.Model(&addedProduct).Select(); err != nil {
-		tx.Rollback()
+		_ = tx.Rollback()
 		http.Error(w, err.Error(), errToStatusCode(err))
 		return
 	}
 
 	order.Products = append(order.Products, addedProduct)
 	if _, err := tx.Model(&order).Insert(); err != nil {
-		tx.Rollback()
+		_ = tx.Rollback()
 		http.Error(w, err.Error(), errToStatusCode(err))
 		return
 	}
@@ -353,7 +353,7 @@ func (s *Server) addProductToOrder(w http.ResponseWriter, r *http.Request, ps ht
 		Product: addedProduct,
 	}
 	if _, err := tx.Model(&orderProduct).Insert(); err != nil {
-		tx.Rollback()
+		_ = tx.Rollback()
 		http.Error(w, err.Error(), errToStatusCode(err))
 		return
 	}

go/gorm/main.go

@@ -36,7 +36,9 @@ func setupDB(addr string) *gorm.DB {
 	}
 
 	// Migrate the schema
-	db.AutoMigrate(&model.Customer{}, &model.Order{}, &model.Product{})
+	if err := db.AutoMigrate(&model.Customer{}, &model.Order{}, &model.Product{}); err != nil {
+		panic(err)
+	}
 
 	return db
 }

go/gorm/server.go

@@ -248,29 +248,29 @@ func (s *Server) addProductToOrder(w http.ResponseWriter, r *http.Request, ps ht
 	var order model.Order
 	orderID := ps.ByName("orderID")
 	if err := tx.Preload("Products").First(&order, orderID).Error; err != nil {
-		tx.Rollback()
+		_ = tx.Rollback()
 		http.Error(w, err.Error(), errToStatusCode(err))
 		return
 	}
 
 	const productIDParam = "productID"
 	productID := r.URL.Query().Get(productIDParam)
 	if productID == "" {
-		tx.Rollback()
+		_ = tx.Rollback()
 		writeMissingParamError(w, productIDParam)
 		return
 	}
 
 	var addedProduct model.Product
 	if err := tx.First(&addedProduct, productID).Error; err != nil {
-		tx.Rollback()
+		_ = tx.Rollback()
 		http.Error(w, err.Error(), errToStatusCode(err))
 		return
 	}
 
 	order.Products = append(order.Products, addedProduct)
 	if err := tx.Save(&order).Error; err != nil {
-		tx.Rollback()
+		_ = tx.Rollback()
 		http.Error(w, err.Error(), errToStatusCode(err))
 		return
 	}

testing/test_driver.go

@@ -291,7 +291,9 @@ func (td testDriver) queryIDs(t *testing.T, table string) ([]int, error) {
 	var ids []int
 	for rows.Next() {
 		var id int
-		rows.Scan(&id)
+		if err := rows.Scan(&id); err != nil {
+			t.Fatal(err)
+		}
 		ids = append(ids, id)
 	}
 	if err := rows.Err(); err != nil {
@@ -336,7 +338,9 @@ func rowsToStringSlice(rows *sql.Rows) ([]string, error) {
 
 	var s []string
 	for rows.Next() {
-		rows.Scan(vals...)
+		if err := rows.Scan(vals...); err != nil {
+			return nil, err
+		}
 		s = append(s, strings.Join(strs, ", "))
 	}
 	if err := rows.Err(); err != nil {