-
Notifications
You must be signed in to change notification settings - Fork 38
Description
I'm currently translating some of the Java/Hibernate examples to jOOQ and found a few issues that you may or may not want to address:
CustomerService::deleteCustomer fails when orders have OrderProduct entries:
This query here:
examples-orms/java/hibernate/src/main/java/com/cockroachlabs/services/CustomerService.java
Line 83 in 8aacfca
| Query deleteReferencing = session.createQuery("delete from Order where customer_id = :id"); |
Will fail in case there are entries in order_products, which does not have ON DELETE CASCADE clauses on its foreign keys by default (I think). I'm not sure if this is desired here.
OrderService::deleteOrder fails because of wrong query:
This query here:
examples-orms/java/hibernate/src/main/java/com/cockroachlabs/services/OrderService.java
Line 83 in 8aacfca
| Query deleteReferencing = session.createQuery("delete from Order where order_id = :id"); |
Will fail because the Order entity doesn't have an order_id column. I think the intention here was to delete the record in order_products