Dynamically detect libgeos version instead of hardcoding#344
Merged
Conversation
rail
force-pushed
the
rail/pr-wvroxkuyrnnk
branch
6 times, most recently
from
51f2e70 to
1973560
Compare
- Add detect_libgeos_name() method that inspects library dependencies: - macOS: uses otool -L to read dylib dependencies from source file - Linux: uses patchelf --print-needed to read .so dependencies after install - Remove all hardcoded version checks (23.2.0, 25.4.0) and version-specific libgeos library names (3.8.1, 3.11.2, 3.13.1) - Works with both versioned (libgeos.so.3.11.2) and unversioned (libgeos.so) library names on Linux - Regenerate all cockroach formulas with the updated template
rail
force-pushed
the
rail/pr-wvroxkuyrnnk
branch
from
1973560 to
4604c78
Compare
rail
changed the title
celiala
approved these changes
Dec 9, 2025
| @@ -0,0 +1 @@ | |||
| common --noenable_bzlmod | |||
Contributor
There was a problem hiding this comment.
(Required for compatibility with Bazel 6.0+, the repo still uses the legacy WORKSPACE approach)
Member
Author
There was a problem hiding this comment.
I added it so Basel doesn’t generate mod files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libgeos library names (3.8.1, 3.11.2, 3.13.1)
library names on Linux