objstorageprovider: propagate errIsNotExist fn in remoteReadable

Fixes: cockroachdb/cockroach#154032

Author: annrpom

metamorphic/build.go

@@ -264,7 +264,7 @@ func openExternalObj(
 	opts := t.opts.MakeReaderOptions()
 	reader, err = sstable.NewReader(
 		context.Background(),
-		objstorageprovider.NewRemoteReadable(objReader, objSize),
+		objstorageprovider.NewRemoteReadable(objReader, objSize, t.externalStorage.IsNotExistError),
 		opts,
 	)
 	if err != nil {

objstorage/objstorageprovider/remote_readable.go

@@ -16,10 +16,13 @@ import (
 )
 
 // NewRemoteReadable creates an objstorage.Readable out of a remote.ObjectReader.
-func NewRemoteReadable(objReader remote.ObjectReader, size int64) objstorage.Readable {
+func NewRemoteReadable(
+	objReader remote.ObjectReader, size int64, errIsNotExist func(error) bool,
+) objstorage.Readable {
 	return &remoteReadable{
-		objReader: objReader,
-		size:      size,
+		objReader:     objReader,
+		size:          size,
+		errIsNotExist: errIsNotExist,
 	}
 }
 

tool/db_analyze_data.go

@@ -259,7 +259,7 @@ func (r *remoteStorage) Open(name string) (objstorage.Readable, error) {
 	if err != nil {
 		return nil, err
 	}
-	return objstorageprovider.NewRemoteReadable(objReader, size), nil
+	return objstorageprovider.NewRemoteReadable(objReader, size, r.storage.IsNotExistError), nil
 }
 
 // We avoid files that are very large to prevent excessive memory usage. Note