db: enable columnar blocks by default

By default enable columnar blocks. In the future, the option to configure use
of columnar blocks will be removed altogether, and columnar blocks will always
be used.

Author: jbowens

format_major_version.go

@@ -380,8 +380,9 @@ func (d *DB) TableFormat() sstable.TableFormat {
 		if d.opts.Experimental.EnableValueBlocks == nil || !d.opts.Experimental.EnableValueBlocks() {
 			f = sstable.TableFormatPebblev2
 		}
-	case sstable.TableFormatPebblev5, sstable.TableFormatPebblev6:
-		if d.opts.Experimental.EnableColumnarBlocks == nil || !d.opts.Experimental.EnableColumnarBlocks() {
+	default:
+		if f.BlockColumnar() && (d.opts.Experimental.EnableColumnarBlocks == nil ||
+			!d.opts.Experimental.EnableColumnarBlocks()) {
 			f = sstable.TableFormatPebblev4
 		}
 	}

options.go

@@ -1304,6 +1304,9 @@ func (o *Options) EnsureDefaults() {
 	if o.Experimental.DeletionSizeRatioThreshold == 0 {
 		o.Experimental.DeletionSizeRatioThreshold = sstable.DefaultDeletionSizeRatioThreshold
 	}
+	if o.Experimental.EnableColumnarBlocks == nil {
+		o.Experimental.EnableColumnarBlocks = func() bool { return true }
+	}
 	if o.Experimental.TombstoneDenseCompactionThreshold == 0 {
 		o.Experimental.TombstoneDenseCompactionThreshold = 0.10
 	}

options_test.go

@@ -86,6 +86,7 @@ func TestDefaultOptionsString(t *testing.T) {
   compaction_debt_concurrency=1073741824
   comparer=leveldb.BytewiseComparator
   disable_wal=false
+  enable_columnar_blocks=true
   flush_delay_delete_range=0s
   flush_delay_range_key=0s
   flush_split_bytes=4194304

range_del_test.go

@@ -382,12 +382,12 @@ L3:
 	}
 
 	// TODO(jackson): Create a datadriven test and exercise it on
-	// TableFormatPebblev6 and later format major versions. This test is tightly
+	// TableFormatPebblev5 and later format major versions. This test is tightly
 	// coupled to the current estimated sizes and won't produce the necessary
 	// input LSM structure on later format major versions.
 	versions := []FormatMajorVersion{
 		FormatMinSupported,
-		FormatWALSyncChunks,
+		FormatFlushableIngestExcises,
 	}
 	for _, version := range versions {
 		t.Run(fmt.Sprintf("version-%s", version), func(t *testing.T) {

replay/testdata/replay

@@ -11,7 +11,7 @@ tree
      614      000007.sst
        0      LOCK
      133      MANIFEST-000001
-    1494      OPTIONS-000003
+    1524      OPTIONS-000003
        0      marker.format-version.000001.013
        0      marker.manifest.000001.MANIFEST-000001
             simple/
@@ -21,7 +21,7 @@ tree
       25        000004.log
      586        000005.sst
       85        MANIFEST-000001
-    1494        OPTIONS-000003
+    1524        OPTIONS-000003
        0        marker.format-version.000001.013
        0        marker.manifest.000001.MANIFEST-000001
 
@@ -38,6 +38,7 @@ cat build/OPTIONS-000003
   compaction_debt_concurrency=1073741824
   comparer=pebble.internal.testkeys
   disable_wal=false
+  enable_columnar_blocks=true
   flush_delay_delete_range=0s
   flush_delay_range_key=0s
   flush_split_bytes=4194304

replay/testdata/replay_paced

@@ -14,7 +14,7 @@ tree
        0      LOCK
      133      MANIFEST-000001
      205      MANIFEST-000010
-    1494      OPTIONS-000003
+    1524      OPTIONS-000003
        0      marker.format-version.000001.013
        0      marker.manifest.000002.MANIFEST-000010
             high_read_amp/
@@ -26,7 +26,7 @@ tree
       39        000008.log
      560        000009.sst
      157        MANIFEST-000010
-    1494        OPTIONS-000003
+    1524        OPTIONS-000003
        0        marker.format-version.000001.013
        0        marker.manifest.000001.MANIFEST-000010