Skip to content

db: improve metrics and logs with multiple disks being used by a DB #5328

@sumeerbhola

Description

@sumeerbhola
  • Metrics.LogWriter.FsyncLatency does not distinguish between the primary WAL dir and secondary WAL dir. We should have separate metrics for each. Also, we should include all filesystem operations done for writing the log file in the corresponding latency histogram (i.e., create, write, sync etc.), since we've seen cases where deployments that use a noop fsync show low latency even though other operations may have higher latency.
  • DiskSlowInfo.SafeFormat should include the immediate directory. Currently it does filepath.Base(i.Path), so one cannot tell whether the WAL file is on the primary or secondary.

Jira issue: PEBBLE-1183

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions