db: clean up logic surrounding WALs, flushables #5533
Merged
+67
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document this subtlety that multiple flushable entries may share the same logNum.
These MinRecycleLogNum and SetMinRecycleLogNum methods were only used to ratchet the minimum log num, so this commit consolidates the two under a RatchetMinRecycleLogNum method.
Member
|
This change is |
Adapt TestVersionSetSeqNums to use pebble.Peek to identify the current active MANIFEST. Previously this unit test would use the last MANIFEST file returned by the List call. Additionally, on failure this test now logs the filesystem operations executed during the test.
jbowens
force-pushed
the
flushableCleanup
branch
from
9d274be to
ed8db3d
Compare
xinhaoz
approved these changes
Nov 7, 2025
Member
xinhaoz
left a comment
xinhaoz
left a comment
There was a problem hiding this comment.
@xinhaoz reviewed 1 of 1 files at r1, 4 of 4 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @xxmplus)
wal/failover_manager.go line 529 at r2 (raw file):
wm.recycler.Init(o.MaxNumRecyclableLogs) for _, ll := range initial { wm.recycler.RatchetMinRecycleLogNum(ll.Num + 1)
TIL the meaning of this word outside of slang.
jbowens
commented
Nov 7, 2025
Collaborator
Author
jbowens
left a comment
jbowens
left a comment
There was a problem hiding this comment.
TFTR!
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @xinhaoz and @xxmplus)
wal/failover_manager.go line 529 at r2 (raw file):
Previously, xinhaoz (Xin Hao Zhang) wrote…
TIL the meaning of this word outside of slang.
😎
RaduBerinde
reviewed
Nov 7, 2025
Member
RaduBerinde
left a comment
RaduBerinde
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion
wal/failover_manager.go line 529 at r2 (raw file):
Previously, jbowens (Jackson Owens) wrote…
😎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A handful of small clean up items surrounding WALs and the flushable queue.