Skip to content

Commit f2021ec

Browse files
alan-masrickystewart
authored andcommitted
build,protobuf: stop building unnecessary protobuf
Based on protocolbuffers#56 we need to avoid protobuf compiler to run for Java, Obj-C and C# everytime we build as no one is using these languages anymore. Release note: None
1 parent 557c10d commit f2021ec

File tree

2 files changed

+9
-65
lines changed

2 files changed

+9
-65
lines changed

cmake/libprotoc.cmake

Lines changed: 0 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -15,64 +15,8 @@ set(libprotoc_files
1515
${protobuf_source_dir}/src/google/protobuf/compiler/cpp/cpp_primitive_field.cc
1616
${protobuf_source_dir}/src/google/protobuf/compiler/cpp/cpp_service.cc
1717
${protobuf_source_dir}/src/google/protobuf/compiler/cpp/cpp_string_field.cc
18-
${protobuf_source_dir}/src/google/protobuf/compiler/csharp/csharp_doc_comment.cc
19-
${protobuf_source_dir}/src/google/protobuf/compiler/csharp/csharp_enum.cc
20-
${protobuf_source_dir}/src/google/protobuf/compiler/csharp/csharp_enum_field.cc
21-
${protobuf_source_dir}/src/google/protobuf/compiler/csharp/csharp_field_base.cc
22-
${protobuf_source_dir}/src/google/protobuf/compiler/csharp/csharp_generator.cc
23-
${protobuf_source_dir}/src/google/protobuf/compiler/csharp/csharp_helpers.cc
24-
${protobuf_source_dir}/src/google/protobuf/compiler/csharp/csharp_map_field.cc
25-
${protobuf_source_dir}/src/google/protobuf/compiler/csharp/csharp_message.cc
26-
${protobuf_source_dir}/src/google/protobuf/compiler/csharp/csharp_message_field.cc
27-
${protobuf_source_dir}/src/google/protobuf/compiler/csharp/csharp_primitive_field.cc
28-
${protobuf_source_dir}/src/google/protobuf/compiler/csharp/csharp_reflection_class.cc
29-
${protobuf_source_dir}/src/google/protobuf/compiler/csharp/csharp_repeated_enum_field.cc
30-
${protobuf_source_dir}/src/google/protobuf/compiler/csharp/csharp_repeated_message_field.cc
31-
${protobuf_source_dir}/src/google/protobuf/compiler/csharp/csharp_repeated_primitive_field.cc
32-
${protobuf_source_dir}/src/google/protobuf/compiler/csharp/csharp_source_generator_base.cc
33-
${protobuf_source_dir}/src/google/protobuf/compiler/csharp/csharp_wrapper_field.cc
34-
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_context.cc
35-
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_doc_comment.cc
36-
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_enum.cc
37-
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_enum_field.cc
38-
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_enum_field_lite.cc
39-
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_enum_lite.cc
40-
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_extension.cc
41-
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_extension_lite.cc
42-
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_field.cc
43-
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_file.cc
44-
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_generator.cc
45-
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_generator_factory.cc
46-
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_helpers.cc
47-
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_map_field.cc
48-
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_map_field_lite.cc
49-
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_message.cc
50-
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_message_builder.cc
51-
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_message_builder_lite.cc
52-
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_message_field.cc
53-
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_message_field_lite.cc
54-
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_message_lite.cc
55-
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_name_resolver.cc
56-
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_primitive_field.cc
57-
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_primitive_field_lite.cc
58-
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_service.cc
59-
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_shared_code_generator.cc
60-
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_string_field.cc
61-
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_string_field_lite.cc
6218
${protobuf_source_dir}/src/google/protobuf/compiler/js/js_generator.cc
6319
${protobuf_source_dir}/src/google/protobuf/compiler/js/well_known_types_embed.cc
64-
${protobuf_source_dir}/src/google/protobuf/compiler/objectivec/objectivec_enum.cc
65-
${protobuf_source_dir}/src/google/protobuf/compiler/objectivec/objectivec_enum_field.cc
66-
${protobuf_source_dir}/src/google/protobuf/compiler/objectivec/objectivec_extension.cc
67-
${protobuf_source_dir}/src/google/protobuf/compiler/objectivec/objectivec_field.cc
68-
${protobuf_source_dir}/src/google/protobuf/compiler/objectivec/objectivec_file.cc
69-
${protobuf_source_dir}/src/google/protobuf/compiler/objectivec/objectivec_generator.cc
70-
${protobuf_source_dir}/src/google/protobuf/compiler/objectivec/objectivec_helpers.cc
71-
${protobuf_source_dir}/src/google/protobuf/compiler/objectivec/objectivec_map_field.cc
72-
${protobuf_source_dir}/src/google/protobuf/compiler/objectivec/objectivec_message.cc
73-
${protobuf_source_dir}/src/google/protobuf/compiler/objectivec/objectivec_message_field.cc
74-
${protobuf_source_dir}/src/google/protobuf/compiler/objectivec/objectivec_oneof.cc
75-
${protobuf_source_dir}/src/google/protobuf/compiler/objectivec/objectivec_primitive_field.cc
7620
${protobuf_source_dir}/src/google/protobuf/compiler/php/php_generator.cc
7721
${protobuf_source_dir}/src/google/protobuf/compiler/plugin.cc
7822
${protobuf_source_dir}/src/google/protobuf/compiler/plugin.pb.cc

src/google/protobuf/compiler/main.cc

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,9 @@ int ProtobufMain(int argc, char* argv[]) {
6060
#endif
6161

6262
// Proto2 Java
63-
java::JavaGenerator java_generator;
64-
cli.RegisterGenerator("--java_out", "--java_opt", &java_generator,
65-
"Generate Java source file.");
63+
// java::JavaGenerator java_generator;
64+
// cli.RegisterGenerator("--java_out", "--java_opt", &java_generator,
65+
// "Generate Java source file.");
6666

6767

6868

@@ -82,14 +82,14 @@ int ProtobufMain(int argc, char* argv[]) {
8282
"Generate Ruby source file.");
8383

8484
// CSharp
85-
csharp::Generator csharp_generator;
86-
cli.RegisterGenerator("--csharp_out", "--csharp_opt", &csharp_generator,
87-
"Generate C# source file.");
85+
// csharp::Generator csharp_generator;
86+
// cli.RegisterGenerator("--csharp_out", "--csharp_opt", &csharp_generator,
87+
// "Generate C# source file.");
8888

8989
// Objective-C
90-
objectivec::ObjectiveCGenerator objc_generator;
91-
cli.RegisterGenerator("--objc_out", "--objc_opt", &objc_generator,
92-
"Generate Objective-C header and source.");
90+
//objectivec::ObjectiveCGenerator objc_generator;
91+
//cli.RegisterGenerator("--objc_out", "--objc_opt", &objc_generator,
92+
// "Generate Objective-C header and source.");
9393

9494
// JavaScript
9595
js::Generator js_generator;

0 commit comments

Comments
 (0)