Revert "improving logging for subcommand failure (bazel-contrib#3824)"

rickystewart · rickystewart · commit 0e7e4e31aa49 · 2024-03-15T13:34:49.000-05:00
This reverts commit 55ea579.
diff --git a/go/tools/builders/env.go b/go/tools/builders/env.go
@@ -196,7 +196,7 @@ func runAndLogCommand(cmd *exec.Cmd, verbose bool) error {
 	cleanup := passLongArgsInResponseFiles(cmd)
 	defer cleanup()
 	if err := cmd.Run(); err != nil {
-		return fmt.Errorf("error running subcommand %s: %w", formatCommand(cmd), err)
+		return fmt.Errorf("error running subcommand %s: %v", cmd.Path, err)
 	}
 	return nil
 }

Original file line number	Diff line number	Diff line change
`@@ -196,7 +196,7 @@ func runAndLogCommand(cmd *exec.Cmd, verbose bool) error {`
`196`	`196`	`cleanup := passLongArgsInResponseFiles(cmd)`
`197`	`197`	`defer cleanup()`
`198`	`198`	`if err := cmd.Run(); err != nil {`
`199`		`- return fmt.Errorf("error running subcommand %s: %w", formatCommand(cmd), err)`
	`199`	`+ return fmt.Errorf("error running subcommand %s: %v", cmd.Path, err)`
`200`	`200`	`}`
`201`	`201`	`return nil`
`202`	`202`	`}`