Skip to content

Commit 1663746

Browse files
authored
fix: make the stats more reasonable and clear (#928)
1 parent 7116245 commit 1663746

File tree

2 files changed

+20
-6
lines changed

2 files changed

+20
-6
lines changed

src/execution/row_indexer.rs

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -369,12 +369,10 @@ impl<'a> RowIndexer<'a> {
369369

370370
if let Some(existing_version) = existing_version {
371371
if output.is_some() {
372-
if !source_version.ordinal.is_available()
373-
|| source_version.ordinal != existing_version.ordinal
374-
{
375-
self.update_stats.num_updates.inc(1);
376-
} else {
372+
if existing_version.kind == SourceVersionKind::DifferentLogic {
377373
self.update_stats.num_reprocesses.inc(1);
374+
} else {
375+
self.update_stats.num_updates.inc(1);
378376
}
379377
} else {
380378
self.update_stats.num_deletions.inc(1);

src/execution/stats.rs

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,8 +115,24 @@ impl std::fmt::Display for UpdateStats {
115115
let num_reprocesses = self.num_reprocesses.get();
116116
let num_source_rows = num_insertions + num_deletions + num_updates + num_reprocesses;
117117
if num_source_rows > 0 {
118+
let mut sub_messages = Vec::new();
119+
if num_insertions > 0 {
120+
sub_messages.push(format!("{num_insertions} ADDED"));
121+
}
122+
if num_deletions > 0 {
123+
sub_messages.push(format!("{num_deletions} REMOVED"));
124+
}
125+
if num_reprocesses > 0 {
126+
sub_messages.push(format!(
127+
"{num_reprocesses} REPROCESSED due to flow or logic changes"
128+
));
129+
}
130+
if num_updates > 0 {
131+
sub_messages.push(format!("{num_updates} UPDATED in source content"));
132+
}
118133
messages.push(format!(
119-
"{num_source_rows} source rows processed ({num_insertions} ADDED, {num_deletions} REMOVED, {num_updates} UPDATED, {num_reprocesses} REPROCESSED on flow or logic changes)",
134+
"{num_source_rows} source rows processed ({})",
135+
sub_messages.join(", "),
120136
));
121137
}
122138

0 commit comments

Comments
 (0)