fix: avoid unncessary holding of ProcessPoolExecutor to allow its GC

georgeh0 · georgeh0 · commit 697d65fa782d · 2025-08-31T12:48:46.000-07:00
diff --git a/python/cocoindex/subprocess_exec.py b/python/cocoindex/subprocess_exec.py
@@ -238,11 +238,9 @@ def _sp_call(key_bytes: bytes, args: tuple[Any, ...], kwargs: dict[str, Any]) ->
 
 
 class _ExecutorStub:
-    _pool: ProcessPoolExecutor
     _key_bytes: bytes
 
     def __init__(self, executor_factory: type[Any], spec: Any) -> None:
-        self._pool = _get_pool()
         self._key_bytes = pickle.dumps(
             (executor_factory, spec), protocol=pickle.HIGHEST_PROTOCOL
         )

Original file line number	Diff line number	Diff line change
`@@ -238,11 +238,9 @@ def _sp_call(key_bytes: bytes, args: tuple[Any, ...], kwargs: dict[str, Any]) ->`
`238`	`238`
`239`	`239`
`240`	`240`	`class _ExecutorStub:`
`241`		`- _pool: ProcessPoolExecutor`
`242`	`241`	`_key_bytes: bytes`
`243`	`242`
`244`	`243`	`def __init__(self, executor_factory: type[Any], spec: Any) -> None:`
`245`		`- self._pool = _get_pool()`
`246`	`244`	`self._key_bytes = pickle.dumps(`
`247`	`245`	`(executor_factory, spec), protocol=pickle.HIGHEST_PROTOCOL`
`248`	`246`	`)`