Skip to content

Commit 72aa5c1

Browse files
committed
Fix validation logic for behavior_version
1 parent a374e91 commit 72aa5c1

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

src/builder/analyzer.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -716,7 +716,7 @@ impl<'a> AnalyzerContext<'a> {
716716
output_type: output_type.typ.clone(),
717717
};
718718
if function_exec_info.enable_cache
719-
&& function_exec_info.behavior_version.is_some()
719+
&& function_exec_info.behavior_version.is_none()
720720
{
721721
api_bail!(
722722
"When caching is enabled, behavior version must be specified for transform op: {}",

src/ops/py_factory.rs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -266,13 +266,13 @@ impl SimpleFunctionFactory for PyFunctionFactory {
266266
let (enable_cache, behavior_version) =
267267
Python::with_gil(|py| -> anyhow::Result<_> {
268268
executor.call_method(py, "prepare", (), None)?;
269-
let enable_cache = executor.call_method(py, "enable_cache", (), None)?;
270-
let behavior_version =
271-
executor.call_method(py, "behavior_version", (), None)?;
272-
Ok((
273-
enable_cache.extract::<bool>(py)?,
274-
behavior_version.extract::<Option<u32>>(py)?,
275-
))
269+
let enable_cache = executor
270+
.call_method(py, "enable_cache", (), None)?
271+
.extract::<bool>(py)?;
272+
let behavior_version = executor
273+
.call_method(py, "behavior_version", (), None)?
274+
.extract::<Option<u32>>(py)?;
275+
Ok((enable_cache, behavior_version))
276276
})?;
277277
Ok(Box::new(Arc::new(PyFunctionExecutor {
278278
py_function_executor: executor,

0 commit comments

Comments
 (0)