fix: only pass down output_dimension when not default (#647)

Author: badmonster0

src/llm/mod.rs

@@ -56,7 +56,7 @@ pub trait LlmGenerationClient: Send + Sync {
 pub struct LlmEmbeddingRequest<'a> {
     pub model: &'a str,
     pub text: Cow<'a, str>,
-    pub output_dimension: u32,
+    pub output_dimension: Option<u32>,
     pub task_type: Option<Cow<'a, str>>,
 }
 

src/llm/openai.rs

@@ -129,7 +129,7 @@ impl LlmEmbeddingClient for Client {
             .create(CreateEmbeddingRequest {
                 model: request.model.to_string(),
                 input: EmbeddingInput::String(request.text.to_string()),
-                dimensions: Some(request.output_dimension),
+                dimensions: request.output_dimension,
                 ..Default::default()
             })
             .await?;

src/ops/functions/embed_text.rs

@@ -14,7 +14,6 @@ struct Spec {
 
 struct Args {
     client: Box<dyn LlmEmbeddingClient>,
-    output_dimension: u32,
     text: ResolvedOpArg,
 }
 
@@ -38,7 +37,7 @@ impl SimpleFunctionExecutor for Executor {
         let req = LlmEmbeddingRequest {
             model: &self.spec.model,
             text: Cow::Borrowed(text),
-            output_dimension: self.args.output_dimension,
+            output_dimension: self.spec.output_dimension,
             task_type: self
                 .spec
                 .task_type
@@ -80,14 +79,7 @@ impl SimpleFunctionFactoryBase for Factory {
             dimension: Some(output_dimension as usize),
             element_type: Box::new(BasicValueType::Float32),
         }));
-        Ok((
-            Args {
-                client,
-                text,
-                output_dimension,
-            },
-            output_schema,
-        ))
+        Ok((Args { client, text }, output_schema))
     }
 
     async fn build_executor(