fix: let bytes_to_string() return Cow to avoid unnecessary copy

Author: georgeh0

src/base/value.rs

@@ -115,6 +115,12 @@ impl From<String> for KeyPart {
     }
 }
 
+impl From<Cow<'_, str>> for KeyPart {
+    fn from(value: Cow<'_, str>) -> Self {
+        KeyPart::Str(Arc::from(value))
+    }
+}
+
 impl From<bool> for KeyPart {
     fn from(value: bool) -> Self {
         KeyPart::Bool(value)
@@ -522,6 +528,12 @@ impl From<String> for BasicValue {
     }
 }
 
+impl From<Cow<'_, str>> for BasicValue {
+    fn from(value: Cow<'_, str>) -> Self {
+        BasicValue::Str(Arc::from(value))
+    }
+}
+
 impl From<bool> for BasicValue {
     fn from(value: bool) -> Self {
         BasicValue::Bool(value)

src/ops/sources/google_drive.rs

@@ -400,7 +400,8 @@ impl SourceExecutor for Executor {
                     if self.binary {
                         content.to_bytes().to_vec().into()
                     } else {
-                        let (s, _) = utils::bytes_decode::bytes_to_string(&content.to_bytes());
+                        let bytes = content.to_bytes();
+                        let (s, _) = utils::bytes_decode::bytes_to_string(&bytes);
                         s.into()
                     },
                 ];

src/utils/bytes_decode.rs

@@ -1,12 +1,12 @@
 use encoding_rs::Encoding;
 
-pub fn bytes_to_string(bytes: &[u8]) -> (String, bool) {
+pub fn bytes_to_string<'a>(bytes: &'a [u8]) -> (std::borrow::Cow<'a, str>, bool) {
     // 1) BOM sniff first (definitive for UTF-8/16; UTF-32 is not supported here).
     if let Some((enc, bom_len)) = Encoding::for_bom(bytes) {
         let (cow, had_errors) = enc.decode_without_bom_handling(&bytes[bom_len..]);
-        return (cow.into_owned(), had_errors);
+        return (cow, had_errors);
     }
     // 2) Otherwise, try UTF-8 (accepts input with or without a UTF-8 BOM).
     let (cow, had_errors) = encoding_rs::UTF_8.decode_with_bom_removal(bytes);
-    (cow.into_owned(), had_errors)
+    (cow, had_errors)
 }