Feature: Enable programmatically pass in api_key besides reading from env

Author: aryasoni98

src/llm/anthropic.rs

@@ -14,11 +14,7 @@ pub struct Client {
 }
 
 impl Client {
-    pub async fn new(
-        address: Option<String>,
-        api_key: Option<String>,
-        _api_config: Option<super::LlmApiConfig>,
-    ) -> Result<Self> {
+    pub async fn new(address: Option<String>, api_key: Option<String>) -> Result<Self> {
         if address.is_some() {
             api_bail!("Anthropic doesn't support custom API address");
         }

src/llm/gemini.rs

@@ -34,11 +34,7 @@ pub struct AiStudioClient {
 }
 
 impl AiStudioClient {
-    pub fn new(
-        address: Option<String>,
-        api_key: Option<String>,
-        _api_config: Option<super::LlmApiConfig>,
-    ) -> Result<Self> {
+    pub fn new(address: Option<String>, api_key: Option<String>) -> Result<Self> {
         if address.is_some() {
             api_bail!("Gemini doesn't support custom API address");
         }

src/llm/litellm.rs

@@ -7,7 +7,6 @@ impl Client {
     pub async fn new_litellm(
         address: Option<String>,
         api_key: Option<String>,
-        _api_config: Option<super::LlmApiConfig>,
     ) -> anyhow::Result<Self> {
         let address = address.unwrap_or_else(|| "http://127.0.0.1:4000".to_string());
 

src/llm/mod.rs

@@ -127,28 +127,28 @@ pub async fn new_llm_generation_client(
         }
         LlmApiType::OpenAi => Box::new(openai::Client::new(address, api_key, api_config)?)
             as Box<dyn LlmGenerationClient>,
-        LlmApiType::Gemini => Box::new(gemini::AiStudioClient::new(address, api_key, api_config)?)
+        LlmApiType::Gemini => Box::new(gemini::AiStudioClient::new(address, api_key)?)
             as Box<dyn LlmGenerationClient>,
         LlmApiType::VertexAi => {
             Box::new(gemini::VertexAiClient::new(address, api_key, api_config).await?)
                 as Box<dyn LlmGenerationClient>
         }
         LlmApiType::Anthropic => {
-            Box::new(anthropic::Client::new(address, api_key, api_config).await?)
+            Box::new(anthropic::Client::new(address, api_key).await?)
                 as Box<dyn LlmGenerationClient>
         }
         LlmApiType::LiteLlm => {
-            Box::new(litellm::Client::new_litellm(address, api_key, api_config).await?)
+            Box::new(litellm::Client::new_litellm(address, api_key).await?)
                 as Box<dyn LlmGenerationClient>
         }
         LlmApiType::OpenRouter => {
-            Box::new(openrouter::Client::new_openrouter(address, api_key, api_config).await?)
+            Box::new(openrouter::Client::new_openrouter(address, api_key).await?)
                 as Box<dyn LlmGenerationClient>
         }
         LlmApiType::Voyage => {
             api_bail!("Voyage is not supported for generation")
         }
-        LlmApiType::Vllm => Box::new(vllm::Client::new_vllm(address, api_key, api_config).await?)
+        LlmApiType::Vllm => Box::new(vllm::Client::new_vllm(address, api_key).await?)
             as Box<dyn LlmGenerationClient>,
     };
     Ok(client)
@@ -164,11 +164,11 @@ pub async fn new_llm_embedding_client(
         LlmApiType::Ollama => {
             Box::new(ollama::Client::new(address).await?) as Box<dyn LlmEmbeddingClient>
         }
-        LlmApiType::Gemini => Box::new(gemini::AiStudioClient::new(address, api_key, api_config)?)
+        LlmApiType::Gemini => Box::new(gemini::AiStudioClient::new(address, api_key)?)
             as Box<dyn LlmEmbeddingClient>,
         LlmApiType::OpenAi => Box::new(openai::Client::new(address, api_key, api_config)?)
             as Box<dyn LlmEmbeddingClient>,
-        LlmApiType::Voyage => Box::new(voyage::Client::new(address, api_key, api_config)?)
+        LlmApiType::Voyage => Box::new(voyage::Client::new(address, api_key)?)
             as Box<dyn LlmEmbeddingClient>,
         LlmApiType::VertexAi => {
             Box::new(gemini::VertexAiClient::new(address, api_key, api_config).await?)

src/llm/openrouter.rs

@@ -7,7 +7,6 @@ impl Client {
     pub async fn new_openrouter(
         address: Option<String>,
         api_key: Option<String>,
-        _api_config: Option<super::LlmApiConfig>,
     ) -> anyhow::Result<Self> {
         let address = address.unwrap_or_else(|| "https://openrouter.ai/api/v1".to_string());
 

src/llm/vllm.rs

@@ -7,7 +7,6 @@ impl Client {
     pub async fn new_vllm(
         address: Option<String>,
         api_key: Option<String>,
-        _api_config: Option<super::LlmApiConfig>,
     ) -> anyhow::Result<Self> {
         let address = address.unwrap_or_else(|| "http://127.0.0.1:8000/v1".to_string());
 

src/llm/voyage.rs

@@ -33,11 +33,7 @@ pub struct Client {
 }
 
 impl Client {
-    pub fn new(
-        address: Option<String>,
-        api_key: Option<String>,
-        _api_config: Option<super::LlmApiConfig>,
-    ) -> Result<Self> {
+    pub fn new(address: Option<String>, api_key: Option<String>) -> Result<Self> {
         if address.is_some() {
             api_bail!("Voyage AI doesn't support custom API address");
         }

src/ops/functions/embed_text.rs

@@ -93,44 +93,11 @@ impl SimpleFunctionFactoryBase for Factory {
             .expect_type(&ValueType::Basic(BasicValueType::Str))?
             .required()?;
 
-        // Create API config based on api_key parameter if provided
-        let api_config = if let Some(_api_key) = &spec.api_key {
-            match spec.api_type {
-                LlmApiType::OpenAi => Some(LlmApiConfig::OpenAi(
-                    super::super::super::llm::OpenAiConfig {
-                        org_id: None,
-                        project_id: None,
-                    },
-                )),
-                LlmApiType::Anthropic
-                | LlmApiType::Gemini
-                | LlmApiType::Voyage
-                | LlmApiType::LiteLlm
-                | LlmApiType::OpenRouter
-                | LlmApiType::Vllm => {
-                    // These API types don't require a config, just an API key
-                    None
-                }
-                _ => {
-                    if let Some(config) = spec.api_config.clone() {
-                        Some(config)
-                    } else {
-                        api_bail!(
-                            "API key parameter is not supported for API type {:?}",
-                            spec.api_type
-                        )
-                    }
-                }
-            }
-        } else {
-            spec.api_config.clone()
-        };
-
         let client = new_llm_embedding_client(
             spec.api_type,
             spec.address.clone(),
             spec.api_key.clone(),
-            api_config,
+            spec.api_config.clone(),
         )
         .await?;
         let output_dimension = match spec.output_dimension {