updated existing tests for split_recursively.rs to be based on public… #1075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgeh0
approved these changes
Oct 1, 2025
Member
georgeh0
left a comment
georgeh0
left a comment
There was a problem hiding this comment.
Mostly look good. One minor refactor recommended. Thanks!
| }; | ||
| let factory = Arc::new(Factory); | ||
|
|
||
| let input_arg_schemas = &[ |
Member
There was a problem hiding this comment.
Consider refactor the logic to build schema into a function and reuse.
Contributor
Author
There was a problem hiding this comment.
@georgeh0 will do it and soon add new commit.
Contributor
Author
There was a problem hiding this comment.
@georgeh0 @badmonster0 defined schema in function and use that for tests and also refactor code a bit. Please review it and if any improvement or changes needed pls tell will do it.
… refactor code a bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the tests of split_recursively.rs to be based on public APIs.
Closes issue: #965
Tests of split_recursively.rs
Tests and linting done:
