Skip to content

Simplify neo4j setup logic by dedicated component management util #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
badmonster0 merged 2 commits into from
Apr 15, 2025
Merged

Simplify neo4j setup logic by dedicated component management util #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abd43d3
Simplify neo4j setup logic by dedicated component management util
badmonster0 Apr 15, 2025
9d4c195
Bug fix: allow vector index not specified for nodes in Python SDK.
badmonster0 Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions python/cocoindex/storages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
"""All builtin storages."""
from dataclasses import dataclass
from typing import Sequence

from . import op
from . import index
Expand Down Expand Up @@ -44,8 +45,9 @@ class Neo4jRelationshipEndSpec:
@dataclass
class Neo4jRelationshipNodeSpec:
"""Spec for a Neo4j node type."""
primary_key_fields: list[str]
vector_indexes: list[index.VectorIndexDef] | None = None
primary_key_fields: Sequence[str]
vector_indexes: Sequence[index.VectorIndexDef] = ()

class Neo4jRelationship(op.StorageSpec):
"""Graph storage powered by Neo4j."""

Expand Down
Loading