feat: add content hash support for change detection in source processing #629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for taking this! It touches a core aspect of cocoindex. Left a few thoughts. Welcome of more discussions! |
badmonster0
reviewed
Jun 18, 2025
Member
badmonster0
left a comment
badmonster0
left a comment
There was a problem hiding this comment.
(sorry I made a few pending comments yesterday but forgot to hit "submit")
…nd streamline related logic
badmonster0
reviewed
Jun 19, 2025
badmonster0
reviewed
Jun 21, 2025
…imize update logic for source processing
badmonster0
reviewed
Jun 21, 2025
…pdate_source_row logic for efficient source processing
badmonster0
reviewed
Jun 21, 2025
…ng process_logic_fingerprint and enhancing content hash optimization logic in update_source_row
badmonster0
reviewed
Jun 24, 2025
…ndling in update_source_row for improved efficiency
badmonster0
reviewed
Jun 25, 2025
….py to streamline test coverage
badmonster0
reviewed
Jun 26, 2025
…sary parameters and enhance EvaluationMemory initialization for better clarity and performance
badmonster0
reviewed
Jun 26, 2025
…king_ordinal and streamline memoization info handling in update_source_row for improved clarity
badmonster0
reviewed
Jun 27, 2025
badmonster0
approved these changes
Jun 27, 2025
Member
badmonster0
left a comment
badmonster0
left a comment
There was a problem hiding this comment.
All look good! Thanks for your patience! 👍
Contributor
Author
|
@badmonster0 |
Member
|
Hi @vumichien, Really appreciate your great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solved issue #621