cc.textureCache.addImageAsync caused crash on Android, iOS, Mac

[0xJimmyBeh]

Crash happen on Android, iOS, Mac. Win32 not tested.

Crash on JSAutoCompartment ac(_cx, _obj.ref() ? _obj.ref() : global);

Tested with code below :

var imageUrlArray = ["http://www.cocos2d-x.org/s/upload/v35.jpg", "http://www.cocos2d-x.org/s/upload/testin.jpg", "http://www.cocos2d-x.org/s/upload/geometry_dash.jpg"];

for (var i = 0; i < imageUrlArray.length; i++)
{
    cc.textureCache.addImageAsync(imageUrlArray[i], this.imageLoaded, this);
}

#1507 (comment)

Updated : update issues

[pandamicro]

Delayed to v3.7

[0xJimmyBeh]

@pandamicro

Is there any temporarily solution for this issue?

Thanks.

[man2]

is this fixed yet? I can't get it to work on 3.6, is there any quick fix for this?

if there isn't, maybe I have to rollback to 3.3 where it works.

here is my stack trace

signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 00000000
Stack frame #00 pc 00a27548 /data/app-lib/com.jstest-1/libcocos2djs.so (JSAutoCompartment::JSAutoCompartment(JSContext_, JSObject_)+16): Routine JSAutoCompartment::JSAutoCompartment(JSContext_, JSObject_) at ??:?
Stack frame #1 pc 010951f4 /data/app-lib/com.jstest-1/libcocos2djs.so (__JSDownloaderDelegator::onSuccess(std::string const&, std::string const&, std::string const&)+304): Routine __JSDownloaderDelegator::onSuccess(std::string const&, std::string const&, std::string const&) at /Users/Documents/cocos/frameworks/runtime-src/proj.android/../../js-bindings/bindings/manual/extension/jsb_cocos2dx_extension_manual.cpp:976 (discriminator 4)

[stnguyen]

this is a serious bug. anybody has a workaround for it while we wait for the official fix?

[0xJimmyBeh]

Yes, this is a critical bug but been delayed to fix from v3.6 to v3.7.
I hope it can be fixed ASAP and won't be delayed to v3.8.

It looks like TextureCache::addImageAsync has more issue on Cocos2d-x
cocos2d/cocos2d-x#12021

For temporarily solution, i make the downloader become sync which has the old time app freeze issue.
Modify the file at /frameworks/js-bindings/bindings/manual/extension/jsb_cocos2dx_extension_manual.cpp

void __JSDownloaderDelegator::download(JSContext *cx, JS::HandleObject obj, const std::string &url, JS::HandleValue callback)
{
//auto t = std::thread(cx, obj, url, callback {
new __JSDownloaderDelegator(cx, obj, url, callback);
//});
//t.detach();
}

[pwang08]

Maybe I have fixed this issue. Modify the file at /frameworks/js-bindings/bindings/manual/extension/jsb_cocos2dx_extension_manual.cpp

void __JSDownloaderDelegator::downloadSync(JSContext *cx, JS::HandleObject obj, const std::string &url, JS::HandleValue callback)
{
    new __JSDownloaderDelegator(cx, obj, url, callback);
}

// jsb.loadRemoteImg(url, function(succeed, result) {})
bool js_load_remote_image(JSContext *cx, uint32_t argc, jsval *vp)
{
    if (argc == 2) {
        auto t = std::thread([cx, argc, vp]() {
            JS::CallArgs args = JS::CallArgsFromVp(argc, vp);
            JS::RootedObject obj(cx, JS_THIS_OBJECT(cx, vp));
            std::string url;
            bool ok = jsval_to_std_string(cx, args.get(0), &url);
            JS::RootedValue callback(cx, args.get(1));

            __JSDownloaderDelegator::downloadSync(cx, obj, url, callback);

            JSB_PRECONDITION2(ok, cx, false, "js_console_log : Error processing arguments");

            args.rval().setUndefined();
        });
        t.detach();
        return true;
    }

    JS_ReportError(cx, "js_load_remote_image : wrong number of arguments");
    return false;
}

Ok, it works now!

[0xJimmyBeh]

@pwang08
Does your solution have freeze issue when downloading the image?

Thanks.

[pwang08]

@Zinitter I have start a thread to process, so the solution works well.