CCPackageDownload unit test added for 404 response.

Author: NickyWeber

UnitTests/CCPackageDownloadTests.m

@@ -140,7 +140,6 @@ - (void)setUp
     self.downloadError = nil;
     self.downloadSuccessful = NO;
 
-
     self.package = [[CCPackage alloc] initWithName:@"testpackage"
                                         resolution:@"phonehd"
                                                 os:@"iOS"
@@ -186,18 +185,21 @@ - (void)createDownloadFolder
 
 - (void)testDownloadPackage
 {
-    [self startDownloadAndWaitForDelegateToReturn];
+    [self waitForDelegateToReturnAfterRunningBlock:^
+    {
+        [_download start];
+    }];
 
     NSFileManager *fileManager = [NSFileManager defaultManager];
     NSDictionary *attribs = [fileManager attributesOfItemAtPath:_localURL.path error:nil];
-
+    XCTAssertTrue(_downloadSuccessful);
     XCTAssertTrue([fileManager fileExistsAtPath:_localURL.path]);
     XCTAssertEqual([attribs[NSFileSize] unsignedIntegerValue], __fileDownloadSize);
 }
 
-- (void)startDownloadAndWaitForDelegateToReturn
+- (void)waitForDelegateToReturnAfterRunningBlock:(dispatch_block_t)block
 {
-    [_download start];
+    block();
 
     while (!_downloadReturned)
     {
@@ -207,21 +209,29 @@ - (void)startDownloadAndWaitForDelegateToReturn
 
 - (void)testRangeRequest
 {
-    // Setting up partial download on disk
-    NSString *fileName = [_package.remoteURL lastPathComponent];
-    NSString *pathToPackage = [[NSBundle mainBundle] pathForResource:[NSString stringWithFormat:@"Resources-shared/Packages/%@", fileName] ofType:nil];
-    NSData *data = [[NSData dataWithContentsOfFile:pathToPackage] subdataWithRange:NSMakeRange(0, 5000)];
-    NSString *tempName = [_download performSelector:@selector(createTempName)];
-    [data writeToFile:[[_localURL.path stringByDeletingLastPathComponent] stringByAppendingPathComponent:tempName] atomically:YES];
+    [self setupPartialDownloadOnDisk];
 
-    [self startDownloadAndWaitForDelegateToReturn];
+    [self waitForDelegateToReturnAfterRunningBlock:^
+    {
+        [_download start];
+    }];
 
     NSFileManager *fileManager = [NSFileManager defaultManager];
     NSDictionary *attribs = [fileManager attributesOfItemAtPath:_localURL.path error:nil];
+    XCTAssertTrue(_downloadSuccessful);
     XCTAssertTrue([fileManager fileExistsAtPath:_localURL.path]);
     XCTAssertEqual([attribs[NSFileSize] unsignedIntegerValue], __fileDownloadSize);
 }
 
+- (void)setupPartialDownloadOnDisk
+{
+    NSString *fileName = [_package.remoteURL lastPathComponent];
+    NSString *pathToPackage = [[NSBundle mainBundle] pathForResource:[NSString stringWithFormat:@"Resources-shared/Packages/%@", fileName] ofType:nil];
+    NSData *data = [[NSData dataWithContentsOfFile:pathToPackage] subdataWithRange:NSMakeRange(0, 5000)];
+    NSString *tempName = [_download performSelector:@selector(createTempName)];
+    [data writeToFile:[[_localURL.path stringByDeletingLastPathComponent] stringByAppendingPathComponent:tempName] atomically:YES];
+}
+
 /*
 - (void)testResumeDownloadedPackage
 {
@@ -232,13 +242,21 @@ - (void)testPauseDownload
 {
 
 }
+*/
 
 
 - (void)testDownloadWith404Response
 {
+    [_package setValue:[NSURL URLWithString:@"http://package.request.fake/DOES_NOT_EXIST.zip"] forKey:NSStringFromSelector(@selector(remoteURL))];
 
+    [self waitForDelegateToReturnAfterRunningBlock:^
+    {
+        [_download start];
+    }];
+
+    XCTAssertFalse(_downloadSuccessful);
+    XCTAssertNotNil(_downloadError);
 }
-*/
 
 
 #pragma mark - CCPackageDownloadDelegate