Refactoring of error constant names to be closer to what they actually mean.

Author: NickyWeber

cocos2d/CCPackageConstants.h

@@ -1,9 +1,9 @@
 // Errors
 extern NSUInteger const PACKAGE_ERROR_DOWNLOAD_SERVER_RESPONSE_NOT_OK;
 
-extern NSUInteger const PACKAGE_ERROR_INSTALL_PACKAGE_NOT_FOUND;
+extern NSUInteger const PACKAGE_ERROR_INSTALL_UNZIPPED_PACKAGE_NOT_FOUND;
 
-extern NSUInteger const PACKAGE_ERROR_INSTALL_COULD_NOT_MOVE_PACKAGE;
+extern NSUInteger const PACKAGE_ERROR_INSTALL_COULD_NOT_MOVE_PACKAGE_TO_INSTALL_FOLDER;
 
 extern NSUInteger const PACKAGE_ERROR_INSTALL_PACKAGE_EMPTY;
 

cocos2d/CCPackageConstants.m

@@ -4,9 +4,9 @@
 // Errors
 NSUInteger const PACKAGE_ERROR_DOWNLOAD_SERVER_RESPONSE_NOT_OK = 10000;
 
-NSUInteger const PACKAGE_ERROR_INSTALL_PACKAGE_NOT_FOUND = 10010;
+NSUInteger const PACKAGE_ERROR_INSTALL_UNZIPPED_PACKAGE_NOT_FOUND = 10010;
 
-NSUInteger const PACKAGE_ERROR_INSTALL_COULD_NOT_MOVE_PACKAGE = 10011;
+NSUInteger const PACKAGE_ERROR_INSTALL_COULD_NOT_MOVE_PACKAGE_TO_INSTALL_FOLDER = 10011;
 
 NSUInteger const PACKAGE_ERROR_INSTALL_PACKAGE_EMPTY = 10012;
 

cocos2d/CCPackageInstaller.m

@@ -39,7 +39,7 @@ - (BOOL)installWithError:(NSError **)error
     NSAssert(installData != nil, @"installData must not be nil");
     NSAssert(installData.unzipURL != nil, @"installData.unzipURL must not be nil");
 
-    if (![self packageExists:error])
+    if (![self unzippedPackageFolderExists:error])
     {
         [_package setValue:@(CCPackageStatusInstallationFailed) forKey:@"status"];
         return NO;
@@ -88,7 +88,7 @@ - (BOOL)movePackageToInstallPathWithError:(NSError **)error
         [_package setValue:nil forKey:@"installURL"];
 
         [self setNewError:error
-                     code:PACKAGE_ERROR_INSTALL_COULD_NOT_MOVE_PACKAGE
+                     code:PACKAGE_ERROR_INSTALL_COULD_NOT_MOVE_PACKAGE_TO_INSTALL_FOLDER
                   message:[NSString stringWithFormat:@"Could not move package to install path \"%@\", underlying error: %@", _installPath, errorMove]
           underlyingError:errorMove];
 
@@ -100,7 +100,7 @@ - (BOOL)movePackageToInstallPathWithError:(NSError **)error
     return YES;
 }
 
-- (BOOL)packageExists:(NSError **)error
+- (BOOL)unzippedPackageFolderExists:(NSError **)error
 {
     CCPackageInstallData *installData = [_package installData];
     NSAssert(installData.unzipURL, @"installData.unzipURL must not be nil");
@@ -109,7 +109,7 @@ - (BOOL)packageExists:(NSError **)error
     if (![fileManager fileExistsAtPath:installData.unzipURL.path])
     {
         [self setNewError:error
-                     code:PACKAGE_ERROR_INSTALL_PACKAGE_NOT_FOUND
+                     code:PACKAGE_ERROR_INSTALL_UNZIPPED_PACKAGE_NOT_FOUND
                   message:[NSString stringWithFormat:@"Package to install not found at path \"%@\"", installData.unzipURL]];
 
         CCLOG(@"[PACKAGE/INSTALL][ERROR] Moving unzipped package to installation folder, package already exists! %@", *error);