CCEffectLighting - Directional lighting fix

Thayer J Andrews · Thayer J Andrews · commit 58d38c85734c · 2014-10-08T11:04:35.000-07:00
Normalize the directional light vector after transforming it into the node's tangent space.
diff --git a/cocos2d/CCEffectLighting.m b/cocos2d/CCEffectLighting.m
@@ -193,7 +193,7 @@ -(void)buildRenderPasses
             GLKVector4 lightVector = GLKVector4Make(0.0f, 0.0f, 0.0f, 0.0f);
             if (light.type == CCLightDirectional)
             {
-                lightVector = GLKMatrix4MultiplyVector4(lightNodeToEffectNode, GLKVector4Make(0.0f, 1.0f, 1.0f, 0.0f));
+                lightVector = GLKVector4Normalize(GLKMatrix4MultiplyVector4(lightNodeToEffectNode, GLKVector4Make(0.0f, 1.0f, 1.0f, 0.0f)));
             }
             else
             {

Original file line number	Diff line number	Diff line change
`@@ -193,7 +193,7 @@ -(void)buildRenderPasses`
`193`	`193`	`GLKVector4 lightVector = GLKVector4Make(0.0f, 0.0f, 0.0f, 0.0f);`
`194`	`194`	`if (light.type == CCLightDirectional)`
`195`	`195`	`{`
`196`		`- lightVector = GLKMatrix4MultiplyVector4(lightNodeToEffectNode, GLKVector4Make(0.0f, 1.0f, 1.0f, 0.0f));`
	`196`	`+ lightVector = GLKVector4Normalize(GLKMatrix4MultiplyVector4(lightNodeToEffectNode, GLKVector4Make(0.0f, 1.0f, 1.0f, 0.0f)));`
`197`	`197`	`}`
`198`	`198`	`else`
`199`	`199`	`{`