Skip to content

Commit 74e49be

Browse files
committed
Bugfix: Returning nil in the delegate method customFolderName:packageContents: resulted in an assert exception.
1 parent 154e427 commit 74e49be

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

cocos2d/CCPackageManager.m

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -134,12 +134,6 @@ - (void)loadPackagesFromUserDefaults
134134
{
135135
CCPackage *aPackage = [[CCPackage alloc] initWithDictionary:aPackageDict];
136136

137-
/* TODO
138-
CCPackageInstallData *installData = [[CCPackageInstallData alloc] initWithPackage:aPackage];
139-
[aPackage setInstallData:installData];
140-
[installData populateInstallDataWithDictionary:aPackageDict];
141-
*/
142-
143137
[_packages addObject:aPackage];
144138
CCLOGINFO(@"[PACKAGE][INFO] Package info added: %@: %@", [aPackage standardIdentifier], [aPackage statusToString]);
145139
}
@@ -233,8 +227,6 @@ - (CCPackage *)downloadPackageWithName:(NSString *)name enableAfterDownload:(BOO
233227

234228
- (CCPackage *)downloadPackageWithName:(NSString *)name resolution:(NSString *)resolution enableAfterDownload:(BOOL)enableAfterDownload
235229
{
236-
NSAssert(_baseURL != nil, @"baseURL must not be nil");
237-
238230
NSString *packageName = [NSString stringWithFormat:@"%@-%@-%@.zip", name, [CCPackageHelper currentOS], resolution];
239231
NSURL *remoteURL = [_baseURL URLByAppendingPathComponent:packageName];
240232

@@ -557,6 +549,11 @@ - (BOOL)askDelegateForCustomFolderName:(CCPackage *)package files:(NSArray *)fil
557549
if ([_delegate respondsToSelector:@selector(customFolderName:packageContents:)])
558550
{
559551
NSString *customFolderNameToUse = [_delegate customFolderName:package packageContents:files];
552+
if (!customFolderNameToUse)
553+
{
554+
return NO;
555+
}
556+
560557
if ([fileManager fileExistsAtPath:[package.unzipURL.path stringByAppendingPathComponent:customFolderNameToUse]])
561558
{
562559
package.folderName = customFolderNameToUse;

0 commit comments

Comments
 (0)