CCEffect - Fix signed / unsigned comparison warnings when dealing with pass counts and indices

Since passes are held internally by an NSArray, make the wrapping accessor methods use NSUInteger
for counts and indices as NSArray does.

Author: Thayer J Andrews

cocos2d/CCEffect.m

@@ -492,7 +492,7 @@ -(void)buildRenderPasses
     self.renderPasses = @[];
 }
 
--(NSInteger)renderPassesRequired
+-(NSUInteger)renderPassesRequired
 {
     return _renderPasses.count;
 }
@@ -512,9 +512,9 @@ - (CCEffectPrepareStatus)prepareForRendering
     return CCEffectPrepareNothingToDo;
 }
 
--(CCEffectRenderPass *)renderPassAtIndex:(NSInteger)passIndex
+-(CCEffectRenderPass *)renderPassAtIndex:(NSUInteger)passIndex
 {
-    NSAssert((passIndex >= 0) && (passIndex < _renderPasses.count), @"Pass index out of range.");
+    NSAssert((passIndex < _renderPasses.count), @"Pass index out of range.");
     return _renderPasses[passIndex];
 }
 

cocos2d/CCEffectRenderer.m

@@ -151,7 +151,7 @@ -(void)drawSprite:(CCSprite *)sprite withEffect:(CCEffect *)effect uniforms:(NSM
     [self freeAllRenderTargets];
 
     CCEffectRenderTarget *previousPassRT = nil;
-    for(int i = 0; i < effect.renderPassesRequired; i++)
+    for(NSUInteger i = 0; i < effect.renderPassesRequired; i++)
     {
         BOOL lastPass = (i == (effect.renderPassesRequired - 1));
         BOOL directRendering = lastPass && effect.supportsDirectRendering;

cocos2d/CCEffect_Private.h

@@ -116,7 +116,7 @@ typedef void (^CCEffectRenderPassEndBlock)(CCEffectRenderPass *pass);
 
 @property (nonatomic, readonly) CCShader* shader; // Note: consider adding multiple shaders (one for reach renderpass, this will help break up logic and avoid branching in a potential uber shader).
 @property (nonatomic, readonly) NSMutableDictionary* shaderUniforms;
-@property (nonatomic, readonly) NSInteger renderPassesRequired;
+@property (nonatomic, readonly) NSUInteger renderPassesRequired;
 @property (nonatomic, readonly) BOOL supportsDirectRendering;
 @property (nonatomic, readonly) BOOL readyForRendering;
 
@@ -136,7 +136,7 @@ typedef void (^CCEffectRenderPassEndBlock)(CCEffectRenderPass *pass);
 -(id)initWithFragmentFunction:(NSMutableArray*) fragmentFunctions vertexFunctions:(NSMutableArray*)vertexFunctions fragmentUniforms:(NSArray*)fragmentUniforms vertexUniforms:(NSArray*)vertexUniforms varying:(NSArray*)varying;
 
 -(CCEffectPrepareStatus)prepareForRendering;
--(CCEffectRenderPass *)renderPassAtIndex:(NSInteger)passIndex;
+-(CCEffectRenderPass *)renderPassAtIndex:(NSUInteger)passIndex;
 
 -(BOOL)stitchSupported:(CCEffectFunctionStitchFlags)stitch;