fix render pipeline (#20041)

Author: Mee-gu

cocos/renderer/CCPipelineDescriptor.h

@@ -25,7 +25,6 @@
 
 #include "platform/CCPlatformMacros.h"
 #include "renderer/backend/DepthStencilState.h"
-#include "renderer/backend/BlendState.h"
 #include "renderer/backend/Texture.h"
 #include "renderer/backend/VertexLayout.h"
 #include "renderer/backend/RenderPassDescriptor.h"

cocos/renderer/CCRenderer.cpp

@@ -168,8 +168,6 @@ Renderer::Renderer()
 
     // for the batched TriangleCommand
     _triBatchesToDraw = (TriBatchToDraw*) malloc(sizeof(_triBatchesToDraw[0]) * _triBatchesToDrawCapacity);
-    
-    _renderPipelineCache.reserve(100);
 }
 
 Renderer::~Renderer()
@@ -180,12 +178,7 @@ Renderer::~Renderer()
     free(_triBatchesToDraw);
 
     CC_SAFE_RELEASE(_commandBuffer);
-    
-    for (auto pipeline :_renderPipelineCache)
-    {
-        pipeline.second->release();
-    }
-    _renderPipelineCache.clear();
+    CC_SAFE_RELEASE(_renderPipeline);
 }
 
 void Renderer::init()
@@ -197,6 +190,8 @@ void Renderer::init()
 
     auto device = backend::Device::getInstance();
     _commandBuffer = device->newCommandBuffer();
+    _renderPipeline = device->newRenderPipeline();
+    _commandBuffer->setRenderPipeline(_renderPipeline);
 }
 
 void Renderer::addCommand(RenderCommand* command)
@@ -752,113 +747,20 @@ bool Renderer::checkVisibility(const Mat4 &transform, const Size &size)
     return ret;
 }
 
-backend::RenderPipeline* Renderer::getRenderPipeline(const backend::RenderPipelineDescriptor& renderPipelineDescriptor, const backend::BlendDescriptor blendDescriptor)
-{
-    struct
-    {
-        void* program;
-        unsigned int vertexLayoutInfo[32];
-        backend::PixelFormat colorAttachment;
-        backend::PixelFormat depthAttachment;
-        backend::PixelFormat stencilAttachment;
-        bool blendEnabled;
-        unsigned int writeMask;
-        unsigned int rgbBlendOperation;
-        unsigned int alphaBlendOperation;
-        unsigned int sourceRGBBlendFactor;
-        unsigned int destinationRGBBlendFactor;
-        unsigned int sourceAlphaBlendFactor;
-        unsigned int destinationAlphaBlendFactor;
-    }hashMe;
-    
-    memset(&hashMe, 0, sizeof(hashMe));
-    hashMe.program = renderPipelineDescriptor.programState->getProgram();
-    hashMe.colorAttachment = renderPipelineDescriptor.colorAttachmentsFormat[0];
-    hashMe.depthAttachment = renderPipelineDescriptor.depthAttachmentFormat;
-    hashMe.stencilAttachment = renderPipelineDescriptor.stencilAttachmentFormat;
-    hashMe.blendEnabled = blendDescriptor.blendEnabled;
-    hashMe.writeMask = (unsigned int)blendDescriptor.writeMask;
-    hashMe.rgbBlendOperation = (unsigned int)blendDescriptor.rgbBlendOperation;
-    hashMe.alphaBlendOperation = (unsigned int)blendDescriptor.alphaBlendOperation;
-    hashMe.sourceRGBBlendFactor = (unsigned int)blendDescriptor.sourceRGBBlendFactor;
-    hashMe.destinationRGBBlendFactor = (unsigned int)blendDescriptor.destinationRGBBlendFactor;
-    hashMe.sourceAlphaBlendFactor = (unsigned int)blendDescriptor.sourceAlphaBlendFactor;
-    hashMe.destinationAlphaBlendFactor = (unsigned int)blendDescriptor.destinationAlphaBlendFactor;
-    int index = 0;
-    auto vertexLayout = renderPipelineDescriptor.programState->getVertexLayout();
-    const auto& attributes = vertexLayout->getAttributes();
-    for (const auto& it : attributes)
-    {
-        auto &attribute = it.second;
-        /*
-            stepFunction:1     stride:15       offest:10       format:5        needNormalized:1
-            bit31           bit30 ~ bit16   bit15 ~ bit6    bit5 ~ bit1     bit0
-            */
-        hashMe.vertexLayoutInfo[index++] =
-            ((unsigned int)vertexLayout->getVertexStepMode() & 0x1) << 31 |
-            ((unsigned int)(vertexLayout->getStride() & 0x7FFF)) << 16 |
-            ((unsigned int)attribute.offset & 0x3FF) << 6 |
-            ((unsigned int)attribute.format & 0x1F) << 1 |
-            ((unsigned int)attribute.needToBeNormallized & 0x1);
-    }
-    
-    unsigned int hash = XXH32((const void*)&hashMe, sizeof(hashMe), 0);
-    auto iter = _renderPipelineCache.find(hash);
-    if (_renderPipelineCache.end() == iter)
-    {
-        auto renderPipeline = backend::Device::getInstance()->newRenderPipeline(renderPipelineDescriptor);
-        _renderPipelineCache.emplace(hash, renderPipeline);
-        return renderPipeline;
-    }
-    else
-    {
-        return iter->second;
-    }
-}
-
 void Renderer::setRenderPipeline(const PipelineDescriptor& pipelineDescriptor, const backend::RenderPassDescriptor& renderPassDescriptor)
 {
-    backend::RenderPipelineDescriptor renderPipelineDescriptor;
-    renderPipelineDescriptor.programState = pipelineDescriptor.programState;
-    
     auto device = backend::Device::getInstance();
-    auto blendState = device->createBlendState(pipelineDescriptor.blendDescriptor);
-    renderPipelineDescriptor.blendState = blendState;
-    
-    if (renderPassDescriptor.needColorAttachment)
-    {
-        // FIXME: now just handle color attachment 0.
-        if (renderPassDescriptor.colorAttachmentsTexture[0])
-            renderPipelineDescriptor.colorAttachmentsFormat[0] = renderPassDescriptor.colorAttachmentsTexture[0]->getTextureFormat();
-    }
-    
+    _renderPipeline->update(pipelineDescriptor, renderPassDescriptor);
     backend::DepthStencilState* depthStencilState = nullptr;
     auto needDepthStencilAttachment = renderPassDescriptor.depthTestEnabled || renderPassDescriptor.stencilTestEnabled;
     if (needDepthStencilAttachment)
     {
         depthStencilState = device->createDepthStencilState(_depthStencilDescriptor);
-        
-        if(renderPassDescriptor.depthAttachmentTexture)
-        {
-            renderPipelineDescriptor.depthAttachmentFormat = renderPassDescriptor.depthAttachmentTexture->getTextureFormat();
-        }
-        else
-        {
-            renderPipelineDescriptor.depthAttachmentFormat = PixelFormat::D24S8;
-        }
-    
-        if (renderPassDescriptor.stencilAttachmentTexture)
-        {
-            renderPipelineDescriptor.stencilAttachmentFormat = renderPassDescriptor.stencilAttachmentTexture->getTextureFormat();
-        }
-        else
-        {
-            renderPipelineDescriptor.stencilAttachmentFormat = PixelFormat::D24S8;
-        }
     }
-
-    _commandBuffer->setRenderPipeline(getRenderPipeline(renderPipelineDescriptor, pipelineDescriptor.blendDescriptor));
     _commandBuffer->setDepthStencilState(depthStencilState);
+#ifdef CC_USE_METAL
+    _commandBuffer->setRenderPipeline(_renderPipeline);
+#endif
 }
 
 void Renderer::beginRenderPass(RenderCommand* cmd)

cocos/renderer/CCRenderer.h

@@ -480,13 +480,11 @@ class CC_DLL Renderer
      */
     void setRenderPipeline(const PipelineDescriptor&, const backend::RenderPassDescriptor&);
 
-    backend::RenderPipeline* getRenderPipeline(const backend::RenderPipelineDescriptor& renderPipelineDescriptor, const backend::BlendDescriptor blendDescriptor);
-
     void pushStateBlock();
 
     void popStateBlock();
 
-    std::unordered_map<unsigned int, backend::RenderPipeline*> _renderPipelineCache;
+    backend::RenderPipeline* _renderPipeline = nullptr;
 
     Viewport _viewport;
     CullMode _cullMode  = CullMode::NONE;

cocos/renderer/CMakeLists.txt

@@ -21,7 +21,6 @@ set(COCOS_RENDERER_HEADER
     renderer/ccShaders.h
 
     renderer/backend/Backend.h
-    renderer/backend/BlendState.h
     renderer/backend/Buffer.h
     renderer/backend/CommandBuffer.h
     renderer/backend/DepthStencilState.h
@@ -61,7 +60,6 @@ set(COCOS_RENDERER_SRC
     renderer/CCTrianglesCommand.cpp
     renderer/ccShaders.cpp
 
-    renderer/backend/BlendState.cpp
     renderer/backend/CommandBuffer.cpp
     renderer/backend/DepthStencilState.cpp
     renderer/backend/Device.cpp
@@ -92,7 +90,6 @@ list(APPEND COCOS_RENDERER_HEADER
 )
 
 list(APPEND COCOS_RENDERER_SRC
-    renderer/backend/opengl/BlendStateGL.cpp
     renderer/backend/opengl/BufferGL.cpp
     renderer/backend/opengl/CommandBufferGL.cpp
     renderer/backend/opengl/DepthStencilStateGL.cpp
@@ -108,7 +105,6 @@ list(APPEND COCOS_RENDERER_SRC
 else()
 
 list(APPEND COCOS_RENDERER_HEADER
-    renderer/backend/metal/BlendStateMTL.h
     renderer/backend/metal/BufferMTL.h
     renderer/backend/metal/BufferManager.h
     renderer/backend/metal/CommandBufferMTL.h
@@ -123,7 +119,6 @@ list(APPEND COCOS_RENDERER_HEADER
 )
 
 list(APPEND COCOS_RENDERER_SRC
-    renderer/backend/metal/BlendStateMTL.mm
     renderer/backend/metal/BufferMTL.mm
     renderer/backend/metal/BufferManager.mm
     renderer/backend/metal/CommandBufferMTL.mm

cocos/renderer/backend/Backend.h

@@ -34,4 +34,3 @@
 #include "renderer/backend/VertexLayout.h"
 #include "renderer/backend/Texture.h"
 #include "renderer/backend/DepthStencilState.h"
-#include "renderer/backend/BlendState.h"

cocos/renderer/backend/BlendState.cpp

@@ -30,7 +30,6 @@
 #include "RenderPassDescriptor.h"
 #include "Texture.h"
 #include "DepthStencilState.h"
-#include "BlendState.h"
 #include "ProgramCache.h"
 #include "ShaderCache.h"
 #include "DeviceInfo.h"
@@ -97,19 +96,12 @@ class Device : public cocos2d::Ref
      */
     virtual DepthStencilState* createDepthStencilState(const DepthStencilDescriptor& descriptor) = 0;
 
-    /**
-     * Create an auto released BlendState object.
-     * @param descriptor Specifies blend description.
-     * @return An auto release BlendState object.
-     */
-    virtual BlendState* createBlendState(const BlendDescriptor& descriptor) = 0;
-
     /**
      * New a RenderPipeline object, not auto released.
      * @param descriptor Specifies render pipeline description.
      * @return A RenderPipeline object.
      */
-    virtual RenderPipeline* newRenderPipeline(const RenderPipelineDescriptor& descriptor) = 0;
+    virtual RenderPipeline* newRenderPipeline() = 0;
 
     /**
      * This property controls whether or not the drawables'

cocos/renderer/backend/BlendState.h

@@ -39,6 +39,7 @@
 CC_BACKEND_BEGIN
 
 class TextureBackend;
+class VertexLayout;
 
 /**
  * @addtogroup _backend

cocos/renderer/backend/Device.h

@@ -45,6 +45,7 @@ struct RenderPassDescriptor
 {
     RenderPassDescriptor& operator=(const RenderPassDescriptor& descriptor);
     bool operator==(const RenderPassDescriptor& descriptor) const;
+    bool needDepthStencilAttachment() const { return depthTestEnabled || stencilTestEnabled; }
 
     float clearDepthValue = 0.f;
     float clearStencilValue = 0.f;