Fix android edit box duplicated text (#17775)

* fix editbox textChanged event called after fragment loaded

* fix editbox duplicatd text when change text in textChanged callback

* revert changes of placeholder modification

Author: zilongshanren

cocos/platform/android/java/src/org/cocos2dx/lib/Cocos2dxEditBox.java

@@ -127,6 +127,16 @@ public class Cocos2dxEditBox extends EditText {
     private int mInputModeConstraints;
     private  int mMaxLength;
 
+    public Boolean getChangedTextProgrammatically() {
+        return changedTextProgrammatically;
+    }
+
+    public void setChangedTextProgrammatically(Boolean changedTextProgrammatically) {
+        this.changedTextProgrammatically = changedTextProgrammatically;
+    }
+
+    private Boolean changedTextProgrammatically = false;
+
     //OpenGL view scaleX
     private  float mScaleX;
 

cocos/platform/android/java/src/org/cocos2dx/lib/Cocos2dxEditBoxHelper.java

@@ -126,30 +126,33 @@ public void run() {
                 lParams.gravity = Gravity.TOP | Gravity.LEFT;
 
                 mFrameLayout.addView(editBox, lParams);
-
+                editBox.setTag(false);
                 editBox.addTextChangedListener(new TextWatcher() {
                     @Override
                     public void beforeTextChanged(CharSequence s, int start, int count, int after) {
                     }
 
                     @Override
                     public void onTextChanged(CharSequence s, int start, int before, int count) {
-                        //The optimization can't be turn on due to unknown keyboard hide in some custom keyboard
-//                        mFrameLayout.setEnableForceDoLayout(false);
-
-                        // Note that we must to copy a string to prevent string content is modified
-                        // on UI thread while 's.toString' is invoked at the same time.
-                        final String text = new String(s.toString());
-                        mCocos2dxActivity.runOnGLThread(new Runnable() {
-                            @Override
-                            public void run() {
-                                Cocos2dxEditBoxHelper.__editBoxEditingChanged(index, text);
-                            }
-                        });
+
                     }
 
+                    //http://stackoverflow.com/questions/21713246/addtextchangedlistener-and-ontextchanged-are-always-called-when-android-fragment
+
                     @Override
-                    public void afterTextChanged(Editable s) {
+                    public void afterTextChanged(final Editable s) {
+                        if (!editBox.getChangedTextProgrammatically()) {
+                            if (!s.toString().equals("") && (Boolean) editBox.getTag()) {
+                                mCocos2dxActivity.runOnGLThread(new Runnable() {
+                                    @Override
+                                    public void run() {
+                                        Cocos2dxEditBoxHelper.__editBoxEditingChanged(index, s.toString());
+                                    }
+
+                                });
+                            }
+                        }
+                        editBox.setChangedTextProgrammatically(false);
 
                     }
                 });
@@ -159,6 +162,8 @@ public void afterTextChanged(Editable s) {
 
                     @Override
                     public void onFocusChange(View v, boolean hasFocus) {
+                        editBox.setTag(true);
+                        editBox.setChangedTextProgrammatically(false);
                         if (hasFocus) {
                             mCocos2dxActivity.runOnGLThread(new Runnable() {
                                 @Override
@@ -344,7 +349,10 @@ public static void setText(final int index, final String text){
             public void run() {
                 Cocos2dxEditBox editBox = mEditBoxArray.get(index);
                 if (editBox != null) {
+                    editBox.setChangedTextProgrammatically(true);
                     editBox.setText(text);
+                    int position = text.length();
+                    editBox.setSelection(position);
                 }
             }
         });

cocos/ui/UIEditBox/UIEditBoxImpl-common.cpp

@@ -57,6 +57,7 @@ EditBoxImplCommon::EditBoxImplCommon(EditBox* pEditText)
 , _colPlaceHolder(Color3B::GRAY)
 , _maxLength(-1)
 , _alignment(TextHAlignment::LEFT)
+, _editingMode(false)
 {
 }
 
@@ -232,16 +233,14 @@ void EditBoxImplCommon::refreshInactiveText()
     setInactiveText(_text.c_str());
 
     refreshLabelAlignment();
-
-    if(_text.size() == 0)
-    {
-        _label->setVisible(false);
-        _labelPlaceHolder->setVisible(true);
-    }
-    else
-    {
-        _label->setVisible(true);
-        _labelPlaceHolder->setVisible(false);
+    if (!_editingMode) {
+        if (_text.size() == 0) {
+            _label->setVisible(false);
+            _labelPlaceHolder->setVisible(true);
+        } else {
+            _label->setVisible(true);
+            _labelPlaceHolder->setVisible(false);
+        }
     }
 }
 
@@ -253,19 +252,20 @@ void EditBoxImplCommon::refreshLabelAlignment()
 
 void EditBoxImplCommon::setText(const char* text)
 {
-    this->setNativeText(text);
-    _text = text;
-    refreshInactiveText();
+    if (nullptr != text) {
+        this->setNativeText(text);
+        _text = text;
+        refreshInactiveText();
+    }
 }
 
 void EditBoxImplCommon::setPlaceHolder(const char* pText)
 {
     if (pText != NULL)
     {
         _placeHolder = pText;
-        _labelPlaceHolder->setString(_placeHolder);
-
         this->setNativePlaceHolder(pText);
+        _labelPlaceHolder->setString(_placeHolder);
     }
 }
 
@@ -308,20 +308,21 @@ void EditBoxImplCommon::openKeyboard()
 {
     _label->setVisible(false);
     _labelPlaceHolder->setVisible(false);
-
+    _editingMode = true;
     this->setNativeVisible(true);
     this->nativeOpenKeyboard();
 }
 
 void EditBoxImplCommon::closeKeyboard()
 {
     this->nativeCloseKeyboard();
+    _editingMode = false;
 }
 
 void EditBoxImplCommon::onEndEditing(const std::string& /*text*/)
 {
+    _editingMode = false;
     this->setNativeVisible(false);
-    
     refreshInactiveText();
 }
 

cocos/ui/UIEditBox/UIEditBoxImpl-common.h

@@ -157,6 +157,7 @@ class CC_GUI_DLL EditBoxImplCommon : public EditBoxImpl
 
     int   _maxLength;
     Size _contentSize;
+    bool _editingMode;
 };
 
 

tests/cpp-tests/Classes/UITest/CocoStudioGUITest/UIEditBoxTest.cpp

@@ -152,6 +152,7 @@ void UIEditBoxTest::editBoxEditingDidEndWithAction(cocos2d::ui::EditBox* editBox
 void UIEditBoxTest::editBoxTextChanged(cocos2d::ui::EditBox* editBox, const std::string& text)
 {
     log("editBox %p TextChanged, text: %s ", editBox, text.c_str());
+    editBox->setText(text.c_str());
 }
 
 void UIEditBoxTest::editBoxReturn(ui::EditBox* editBox)