Fix create issue

Bug due to endpoint not accepting json values.

Problem reported in:

* https://bitbucket.org/site/master/issues/12099/error-creating-issue-through-api

Also reported, and solutioned in:

* https://bitbucket.org/site/master/issues/8620/the-repository-issues-components-not

Author: pedrorijo91

src/main/scala/com/codacy/client/bitbucket/client/BitbucketClient.scala

@@ -1,14 +1,13 @@
 package com.codacy.client.bitbucket.client
 
-import java.util.concurrent.{SynchronousQueue, ThreadPoolExecutor, TimeUnit}
-
 import com.codacy.client.bitbucket.util.HTTPStatusCodes
 import com.ning.http.client.AsyncHttpClientConfig
+import java.util.concurrent.{SynchronousQueue, ThreadPoolExecutor, TimeUnit}
+import play.api.http.{ContentTypeOf, Writeable}
 import play.api.libs.json.{JsValue, Json, Reads}
 import play.api.libs.oauth._
 import play.api.libs.ws.DefaultWSClientConfig
 import play.api.libs.ws.ning.{NingAsyncHttpClientConfigBuilder, NingWSClient}
-
 import scala.concurrent.Await
 import scala.concurrent.duration.{Duration, SECONDS}
 import scala.util.{Failure, Properties, Success, Try}
@@ -54,7 +53,8 @@ class BitbucketClient(key: String, secretKey: String, token: String, secretToken
   /*
    * Does an API post
    */
-  def post[T](request: Request[T], values: JsValue)(implicit reader: Reads[T]): RequestResponse[T] = withClientRequest { client =>
+  private def post[D,T](request: Request[T], values: D)(implicit reader: Reads[T], writer: Writeable[D], contentType: ContentTypeOf[D]): RequestResponse[T] = withClientRequest { client =>
+
     val jpromise = client.url(request.url)
       .sign(requestSigner)
       .withFollowRedirects(follow = true)
@@ -78,6 +78,14 @@ class BitbucketClient(key: String, secretKey: String, token: String, secretToken
     value
   }
 
+  def postForm[T](request: Request[T], values: Map[String, Seq[String]])(implicit reader: Reads[T]): RequestResponse[T] = {
+    post(request, values)
+  }
+
+  def postJson[T](request: Request[T], values: JsValue)(implicit reader: Reads[T]): RequestResponse[T] = {
+    post(request, values)
+  }
+
   /* copy paste from post ... */
   def delete[T](url: String): RequestResponse[Boolean] = withClientRequest { client =>
     val jpromise = client.url(url)

src/main/scala/com/codacy/client/bitbucket/service/CommitServices.scala

@@ -14,7 +14,7 @@ class CommitServices(client: BitbucketClient) {
 
     val values = JsObject(params.toSeq :+ "content" -> JsString(body))
 
-    client.post(Request(url, classOf[CommitComment]), values)
+    client.postJson(Request(url, classOf[CommitComment]), values)
   }
 
   def deleteComment(author: String, repo: String, commit: String, commentId: Long): Unit = {

src/main/scala/com/codacy/client/bitbucket/service/HookServices.scala

@@ -1,6 +1,6 @@
 package com.codacy.client.bitbucket.service
 
-import com.codacy.client.bitbucket.{Webhook, Service}
+import com.codacy.client.bitbucket.Webhook
 import com.codacy.client.bitbucket.client.{BitbucketClient, Request, RequestResponse}
 import play.api.libs.json.Json
 
@@ -19,7 +19,8 @@ class HookServices(client: BitbucketClient) {
       "url"         -> hookUrl,
       "events"      -> events
     )
-    client.post(Request(servicesUrl, classOf[Webhook]), payload)
+    
+    client.postJson(Request(servicesUrl, classOf[Webhook]), payload)
   }
 
   def delete(author: String, repo: String, uuid: String): RequestResponse[Boolean] = {

src/main/scala/com/codacy/client/bitbucket/service/IssueServices.scala

@@ -2,19 +2,16 @@ package com.codacy.client.bitbucket.service
 
 import com.codacy.client.bitbucket.Issue
 import com.codacy.client.bitbucket.client.{BitbucketClient, Request, RequestResponse}
-import play.api.libs.json.Json
 
 class IssueServices(client: BitbucketClient) {
 
   def createIssue(author: String, repo: String, title: String, body: String): RequestResponse[Issue] = {
-    val url = s"https://bitbucket.org/!api/1.0/repositories/$author/$repo/issues"
 
-    val values = Json.obj(
-      "title" -> title,
-      "content" -> body
-    )
+    val url = s"https://api.bitbucket.org/1.0/repositories/$author/$repo/issues"
 
-    client.post(Request(url, classOf[Issue]), values)
+    val values = Map("title" -> Seq(title), "content" -> Seq(body))
+
+    client.postForm(Request(url, classOf[Issue]), values)
   }
 
 }

src/main/scala/com/codacy/client/bitbucket/service/PullRequestServices.scala

@@ -45,12 +45,12 @@ class PullRequestServices(client: BitbucketClient) {
       )
     )
 
-    client.post(Request(url, classOf[JsObject]), payload)
+    client.postJson(Request(url, classOf[JsObject]), payload)
   }
 
   def postApprove(owner: String, repository: String, prId: Long): RequestResponse[JsObject] = {
     val url = s"https://bitbucket.org/!api/2.0/repositories/$owner/$repository/pullrequests/$prId/approve"
-    client.post(Request(url, classOf[JsObject]), JsNull)
+    client.postJson(Request(url, classOf[JsObject]), JsNull)
   }
 
   def deleteApprove(owner: String, repository: String, prId: Long): RequestResponse[Boolean] = {
@@ -60,12 +60,12 @@ class PullRequestServices(client: BitbucketClient) {
 
   def merge(owner: String, repository: String, prId: Long): RequestResponse[JsObject] = {
     val url = s"https://bitbucket.org/!api/2.0/repositories/$owner/$repository/pullrequests/$prId/merge"
-    client.post(Request(url, classOf[JsObject]), JsNull)
+    client.postJson(Request(url, classOf[JsObject]), JsNull)
   }
 
   def decline(owner: String, repository: String, prId: Long): RequestResponse[JsObject] = {
     val url = s"https://bitbucket.org/!api/2.0/repositories/$owner/$repository/pullrequests/$prId/decline"
-    client.post(Request(url, classOf[JsObject]), JsNull)
+    client.postJson(Request(url, classOf[JsObject]), JsNull)
   }
 
   def createComment(author: String, repo: String, prId: Int, commitUUID: String, body: String, file: Option[String], line: Option[Int]): RequestResponse[PullRequestComment] = {
@@ -76,7 +76,7 @@ class PullRequestServices(client: BitbucketClient) {
 
     val values = JsObject(params.toSeq :+ "content" -> JsString(body) :+ "anchor" -> JsString(commitUUID.take(12)))
 
-    client.post(Request(url, classOf[PullRequestComment]), values)
+    client.postJson(Request(url, classOf[PullRequestComment]), values)
   }
 
   def deleteComment(author: String, repo: String, commitUUID: String, pullRequestId: Int, commentId: Long): Unit = {

src/main/scala/com/codacy/client/bitbucket/service/RepositoryServices.scala

@@ -33,7 +33,7 @@ class RepositoryServices(client: BitbucketClient) {
       "label" -> "Codacy Key"
     )
 
-    client.post(Request(url, classOf[SshKey]), values)
+    client.postJson(Request(url, classOf[SshKey]), values)
   }
 
 }

src/main/scala/com/codacy/client/bitbucket/service/UrlServices.scala

@@ -9,7 +9,7 @@ class UrlServices(client: BitbucketClient) {
    * Post to a api url
    */
   def post(url: String): RequestResponse[JsObject] = {
-    client.post(Request(url, classOf[JsObject]), JsNull)
+    client.postJson(Request(url, classOf[JsObject]), JsNull)
   }
 
 }

src/main/scala/com/codacy/client/bitbucket/service/UserServices.scala

@@ -31,7 +31,7 @@ class UserServices(client: BitbucketClient) {
       "label" -> "Codacy Key"
     )
 
-    client.post(Request(url, classOf[SshKey]), values)
+    client.postJson(Request(url, classOf[SshKey]), values)
   }
 
 }