Merge pull request #13 from codacy/improve/statusEnum

Make build status as enum

Author: rtfpessoa

src/main/scala/com/codacy/client/bitbucket/BuildStatus.scala

@@ -1,8 +1,15 @@
 package com.codacy.client.bitbucket
 
-import play.api.libs.json._
+import com.codacy.client.bitbucket.util.JsonEnumeration
+import play.api.libs.json.Json
 
-case class BuildStatus(state: String, key: String, name: String, url: String, description: String)
+object CommitStatus extends JsonEnumeration {
+  val InProgress = Value("INPROGRESS")
+  val Successful = Value("SUCCESSFUL")
+  val Failed = Value("FAILED")
+}
+
+case class BuildStatus(state: CommitStatus.Value, key: String, name: String, url: String, description: String)
 
 object BuildStatus {
   implicit val fmt = Json.format[BuildStatus]

src/main/scala/com/codacy/client/bitbucket/service/BuildStatusServices.scala

@@ -24,7 +24,7 @@ class BuildStatusServices(client: BitbucketClient) {
   def createBuildStatus(owner: String, repository: String, commit: String, buildStatus: BuildStatus): RequestResponse[BuildStatus] = {
     val url = s"https://bitbucket.org/!api/2.0/repositories/$owner/$repository/commit/$commit/statuses/build"
 
-    val values = Map("state" -> Seq(buildStatus.state), "key" -> Seq(buildStatus.key),
+    val values = Map("state" -> Seq(buildStatus.state.toString), "key" -> Seq(buildStatus.key),
       "name" -> Seq(buildStatus.name), "url" -> Seq(buildStatus.url),
       "description" -> Seq(buildStatus.description))
 

src/main/scala/com/codacy/client/bitbucket/util/Implicits.scala

@@ -0,0 +1,15 @@
+package com.codacy.client.bitbucket.util
+
+import play.api.data.validation.ValidationError
+import play.api.libs.json.{Json, Reads, Writes}
+import scala.language.implicitConversions
+
+object Implicits {
+
+  implicit def enumWrites[E <: Enumeration#Value]: Writes[E] = Writes((e: E) => Json.toJson(e.toString))
+
+  implicit def enumReads[E <: Enumeration](e: E): Reads[e.Value] = {
+    Reads.StringReads.map { case value => e.values.find(_.toString == value) }.
+      collect(ValidationError("Invalid enumeration value")) { case Some(v) => v }
+  }
+}

src/main/scala/com/codacy/client/bitbucket/util/JsonEnumeration.scala

@@ -0,0 +1,14 @@
+package com.codacy.client.bitbucket.util
+
+import play.api.libs.json.Format
+
+trait JsonEnumeration extends Enumeration {
+  self: Enumeration =>
+
+  implicit lazy val format = Format(Implicits.enumReads(self), Implicits.enumWrites)
+
+  def findByName(name: String): Option[Value] = {
+    values.find(p => p.toString.toLowerCase == name.toLowerCase)
+  }
+
+}