-
Notifications
You must be signed in to change notification settings - Fork 7
infra: upgrade Kubernetes version to 1.32 #818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codacy's Analysis Summary0 new issue (≤ 1 medium issue) Review Pull Request in Codacy →
|
Codacy's Analysis Summary2 new issues, 1 flagged as potential false positive (≤ 1 medium issue) Review Pull Request in Codacy →
|
3b82db0 to
93a6199
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR attempts to upgrade Kubernetes from version 1.30 to 1.33 across infrastructure configurations and CI/CD workflows. However, there are critical issues with the version number and incomplete migration of references.
Key changes:
- Updated K8s version to 1.33 in DigitalOcean cluster Terraform variables and Makefile
- Added new CI/CD test jobs for K8s 1.33 installation
- Updated .gitignore to exclude VSCode AI rules file
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
.gitignore |
Added ignore pattern for VSCode AI rules file (unrelated to K8s bump) |
.do/k8s-cluster/variables.tf |
Updated default Kubernetes version from 1.30.5-do.5 to 1.33.5-do.5 |
.do/k8s-cluster/Makefile |
Updated K8S_VERSION variable from 1.30 to 1.33 |
.circleci/config.yml |
Renamed K8s 1.30 installation jobs to 1.33 and added 1.33 as workflow dependency alongside 1.30 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.do/k8s-cluster/variables.tf
Outdated
| description = "Kubernetes version. See available versions with `doctl kubernetes options versions`" | ||
| type = string | ||
| default = "1.30.5-do.5" | ||
| default = "1.33.5-do.5" |
Copilot
AI
Dec 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Kubernetes version jump from 1.30 to 1.33 skips versions 1.31 and 1.32. Kubernetes follows semantic versioning with sequential minor version releases. Please verify that version 1.33 exists and is the intended target version. If this is meant to be the next version after 1.30, it should likely be 1.31.
| default = "1.33.5-do.5" | |
| default = "1.31.2-do.0" |
.circleci/config.yml
Outdated
| helm_repo: "https://charts.codacy.com/unstable" | ||
| chart_version: $(cat .version) | ||
| microk8s_channel: "1.30/stable" | ||
| microk8s_channel: "1.33/stable" |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
.do/k8s-cluster/Makefile
Outdated
| NGINX_INGRESS_VERSION ?= 4.11.3 | ||
| CERT_MANAGER_VERSION ?= v1.15.0 | ||
| K8S_VERSION ?= 1.30 | ||
| K8S_VERSION ?= 1.33 |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
93a6199 to
897a2ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
897a2ee to
c730afe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.circleci/config.yml
Outdated
| helm_repo: "https://charts.codacy.com/incubator" | ||
| chart_version: $(cat .version) | ||
| microk8s_channel: "1.19/stable" | ||
| microk8s_channel: "1.33/stable" |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
codacy/requirements.yaml
Outdated
| - name: rabbitmq | ||
| version: 7.5.7 | ||
| repository: https://raw.githubusercontent.com/bitnami/charts/defb094c658024e4aa8245622dab202874880cbc/bitnami | ||
| version: 3.8.5 |
Copilot
AI
Dec 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The RabbitMQ chart version is being downgraded from 7.5.7 to 3.8.5, which is a major version downgrade (from v7 to v3). This could introduce breaking changes and data compatibility issues. Please verify that:
- This downgrade is intentional and necessary
- The older version 3.8.5 is compatible with your current RabbitMQ data and configuration
- Any migration steps or data backup procedures have been considered
- This change is not accidentally reverting to an older version instead of moving to a newer compatible version in the legacy repository
cb220ff to
f6e1b97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f6e1b97 to
bccee2b
Compare
bccee2b to
f215c5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.circleci/config.yml
Outdated
| helm_repo: "https://charts.codacy.com/incubator" | ||
| chart_version: $(cat .version) | ||
| microk8s_channel: "1.19/stable" | ||
| microk8s_channel: "1.33/stable" |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
36fce9d to
513473a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - setup_release_db_values | ||
|
|
||
| - codacy/microk8s_install: | ||
| name: install_k8s-1.19_helm-3.9 |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
513473a to
e367901
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
| replicaCount: 1 | ||
| resources: | ||
| limits: | ||
| cpu: 500m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| username: "rabbitmq-codacy" | ||
| password: "rabbitmq-codacy" | ||
| username: rabbitmq-codacy | ||
| password: rabbitmq-codacy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy found an issue: Base64 High Entropy String
No description provided.