Runners use conf files form .codacy

- Removed cli-config.yaml from the repository and updated .gitignore accordingly.
- Added ESLint and Trivy configuration files to the tools-configs directory.
- Modified ESLint and Trivy runner functions to utilize the new configuration files.
- Cleaned up PMD runner to default to the new ruleset configuration if none is specified.

Author: andrzej-janczak

.codacy/cli-config.yaml

@@ -26,4 +26,6 @@ go.work.sum
 
 # Codacy CLI 
 cli-v2
-.codacy/tools-configs
+.codacy/cli-config.yaml
+.codacy/tools-configs
+.codacy/tools-configs/*

.gitignore

@@ -20,7 +20,6 @@ var outputFormat string
 var sarifPath string
 var commitUuid string
 var projectToken string
-var pmdRulesetFile string
 
 type Sarif struct {
 	Runs []struct {
@@ -96,7 +95,6 @@ func init() {
 	analyzeCmd.Flags().StringVarP(&toolToAnalyze, "tool", "t", "", "Which tool to run analysis with")
 	analyzeCmd.Flags().StringVar(&outputFormat, "format", "", "Output format (use 'sarif' for SARIF format)")
 	analyzeCmd.Flags().BoolVar(&autoFix, "fix", false, "Apply auto fix to your issues when available")
-	analyzeCmd.Flags().StringVar(&pmdRulesetFile, "rulesets", "", "Path to PMD ruleset file")
 	rootCmd.AddCommand(analyzeCmd)
 }
 
@@ -209,7 +207,7 @@ func runPmdAnalysis(workDirectory string, pathsToCheck []string, outputFile stri
 	pmd := config.Config.Tools()["pmd"]
 	pmdBinary := pmd.Binaries["pmd"]
 
-	err := tools.RunPmd(workDirectory, pmdBinary, pathsToCheck, outputFile, outputFormat, pmdRulesetFile)
+	err := tools.RunPmd(workDirectory, pmdBinary, pathsToCheck, outputFile, outputFormat, "")
 	if err != nil {
 		log.Fatalf("Error running PMD: %v", err)
 	}

cmd/analyze.go

@@ -143,8 +143,7 @@ func buildRepositoryConfigurationFiles(token string) error {
 	fmt.Println("Building repository configuration files ...")
 	fmt.Println("Fetching repository configuration from codacy ...")
 
-	localCodacyDir := config.Config.LocalCodacyDirectory()
-	toolsConfigDir := filepath.Join(localCodacyDir, "tools-configs")
+	toolsConfigDir := config.Config.ToolsConfigDirectory()
 
 	// Create tools-configs directory if it doesn't exist
 	if err := os.MkdirAll(toolsConfigDir, 0777); err != nil {

cmd/init.go

@@ -15,6 +15,7 @@ type ConfigType struct {
 	runtimesDirectory    string
 	toolsDirectory       string
 	localCodacyDirectory string
+	toolsConfigDirectory string
 	projectConfigFile    string
 	cliConfigFile        string
 
@@ -88,11 +89,16 @@ func (c *ConfigType) AddTools(configs []plugins.ToolConfig) error {
 	return nil
 }
 
+func (c *ConfigType) ToolsConfigDirectory() string {
+	return c.toolsConfigDirectory
+}
+
 func (c *ConfigType) setupCodacyPaths() {
 	c.globalCacheDirectory = filepath.Join(c.homePath, ".cache", "codacy")
 	c.runtimesDirectory = filepath.Join(c.globalCacheDirectory, "runtimes")
 	c.toolsDirectory = filepath.Join(c.globalCacheDirectory, "tools")
 	c.localCodacyDirectory = ".codacy"
+	c.toolsConfigDirectory = filepath.Join(c.localCodacyDirectory, "tools-configs")
 
 	c.projectConfigFile = filepath.Join(c.localCodacyDirectory, "codacy.yaml")
 	c.cliConfigFile = filepath.Join(c.localCodacyDirectory, "cli-config.yaml")

config/config.go

@@ -26,7 +26,6 @@ func CreateEslintConfig(configuration ToolConfiguration) string {
 
 	for _, patternConfiguration := range configuration.PatternsConfiguration {
 		rule := strings.TrimPrefix(patternConfiguration.PatternId, "ESLint8_")
-		fmt.Println("Rule:", rule)
 
 		const tempstring = "TEMPORARYSTRING"
 		rule = strings.ReplaceAll(rule, "__", tempstring)

tools/eslintConfigCreator.go

@@ -14,6 +14,15 @@ func RunEslint(repositoryToAnalyseDirectory string, eslintInstallationDirectory
 	eslintJsPath := filepath.Join(eslintInstallationNodeModules, ".bin", "eslint")
 
 	cmd := exec.Command(nodeBinary, eslintJsPath)
+
+	// For Eslint compatibility with version 8.
+	// https://eslint.org/docs/v8.x/use/configure/configuration-files-new
+	cmd.Env = append(cmd.Env, "ESLINT_USE_FLAT_CONFIG=true")
+
+	// Add config file from tools-configs directory
+	configFile := filepath.Join(".codacy", "tools-configs", "eslint.config.mjs")
+	cmd.Args = append(cmd.Args, "-c", configFile)
+
 	if autoFix {
 		cmd.Args = append(cmd.Args, "--fix")
 	}

tools/eslintRunner.go

@@ -3,39 +3,52 @@ package tools
 import (
 	"os"
 	"os/exec"
+	"path/filepath"
 	"strings"
 )
 
 // RunPmd executes PMD static code analyzer with the specified options
+//
+// Parameters:
+//   - repositoryToAnalyseDirectory: The root directory of the repository to analyze
+//   - pmdBinary: Path to the PMD executable
+//   - pathsToCheck: List of specific paths to analyze, if empty analyzes whole repository
+//   - outputFile: Path where analysis results should be written
+//   - outputFormat: Format for the output (e.g. "sarif")
+//   - rulesetFile: Path to custom ruleset XML file, if empty uses default ruleset
+//
+// Returns:
+//   - error: nil if analysis succeeds or violations found, error otherwise
 func RunPmd(repositoryToAnalyseDirectory string, pmdBinary string, pathsToCheck []string, outputFile string, outputFormat string, rulesetFile string) error {
-	cmdArgs := []string{"pmd"}
+	cmd := exec.Command(pmdBinary, "pmd")
+
+	// Add config file from tools-configs directory if not specified
+	if rulesetFile == "" {
+		configFile := filepath.Join(".codacy", "tools-configs", "pmd-ruleset.xml")
+		cmd.Args = append(cmd.Args, "-R", configFile)
+	} else {
+		cmd.Args = append(cmd.Args, "-R", rulesetFile)
+	}
 
 	// Add source directories (comma-separated list for PMD)
 	if len(pathsToCheck) > 0 {
 		dirArg := strings.Join(pathsToCheck, ",")
-		cmdArgs = append(cmdArgs, "-d", dirArg)
+		cmd.Args = append(cmd.Args, "-d", dirArg)
 	} else {
 		// Fall back to whole repo if no specific paths given
-		cmdArgs = append(cmdArgs, "-d", repositoryToAnalyseDirectory)
-	}
-
-	// Add ruleset
-	if rulesetFile != "" {
-		cmdArgs = append(cmdArgs, "-R", rulesetFile)
+		cmd.Args = append(cmd.Args, "-d", repositoryToAnalyseDirectory)
 	}
 
 	// Format
 	if outputFormat != "" {
-		cmdArgs = append(cmdArgs, "-f", outputFormat)
+		cmd.Args = append(cmd.Args, "-f", outputFormat)
 	}
 
 	// Output file
 	if outputFile != "" {
-		cmdArgs = append(cmdArgs, "-r", outputFile)
+		cmd.Args = append(cmd.Args, "-r", outputFile)
 	}
 
-	cmd := exec.Command(pmdBinary, cmdArgs...)
-
 	cmd.Dir = repositoryToAnalyseDirectory
 	cmd.Stderr = os.Stderr
 	cmd.Stdout = os.Stdout

tools/pmdRunner.go

@@ -14,7 +14,7 @@
       "artifacts": [
         {
           "location": {
-            "uri": "testdata/repositories/test1/src/eslint.config.mjs"
+            "uri": "testdata/repositories/test1/src/.codacy/tools-configs/eslint.config.mjs"
           }
         },
         {