Skip to content

Commit 09c21ad

Browse files
committed
fx eslint
1 parent f24ac3f commit 09c21ad

File tree

4 files changed

+11
-4
lines changed

4 files changed

+11
-4
lines changed

tools/eslint/eslintRunner.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package eslint
22

33
import (
4+
"log"
45
"os"
56
"os/exec"
67
"path/filepath"
@@ -29,7 +30,7 @@ func RunEslint(repositoryToAnalyseDirectory string, eslintInstallationDirectory
2930

3031
// Add config file flag if provided
3132
if configFile != "" {
32-
cmd.Args = append(cmd.Args, "-c", configFile)
33+
cmd.Args = append(cmd.Args, "--config", configFile)
3334
}
3435

3536
if len(pathsToCheck) > 0 {

tools/test/eslint/.eslintrc.json

Lines changed: 0 additions & 1 deletion
This file was deleted.

tools/test/eslint/eslint.config.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
module.exports = {
2+
rules: {
3+
semi: ["error", "always"]
4+
}
5+
};

tools/test/eslint/eslintRunner_test.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ func TestRunEslintToFile(t *testing.T) {
6565

6666
// Use absolute paths
6767
repositoryToAnalyze := testDirectory
68-
eslintInstallDir := filepath.Join(homeDirectory, ".cache/codacy/tools/eslint@8.38.0")
68+
eslintInstallDir := filepath.Join(homeDirectory, ".cache/codacy/tools/eslint@9.3.0")
6969

7070
// Debug logging
7171
log.Printf("Test directory: %s", testDirectory)
@@ -79,7 +79,9 @@ func TestRunEslintToFile(t *testing.T) {
7979
}
8080

8181
// Run ESLint on test.js
82-
eslint.RunEslint(repositoryToAnalyze, eslintInstallDir, nodeBinary, []string{"test.js"}, false, tempResultFile, "sarif", "")
82+
configFile := filepath.Join(testDirectory, "eslint.config.js")
83+
log.Printf("Using ESLint config file: %s", configFile)
84+
eslint.RunEslint(repositoryToAnalyze, eslintInstallDir, nodeBinary, []string{"test.js"}, false, tempResultFile, "sarif", configFile)
8385

8486
// Check if the output file was created
8587
obtainedSarifBytes, err := os.ReadFile(tempResultFile)

0 commit comments

Comments
 (0)