merge and now running pylint fetching the .rc file

Author: franciscoovazevedo

cmd/init.go

@@ -308,6 +308,19 @@ func createToolFileConfigurations(tool tools.Tool, patternConfiguration []domain
 			}
 		}
 		fmt.Println("PMD configuration created based on Codacy settings")
+	case PyLint:
+		if len(patternConfiguration) > 0 {
+			err := createPylintConfigFile(patternConfiguration, toolsConfigDir)
+			if err != nil {
+				return fmt.Errorf("failed to create Pylint config: %v", err)
+			}
+		} else {
+			err := createDefaultPylintConfigFile(toolsConfigDir)
+			if err != nil {
+				return fmt.Errorf("failed to create default Pylint config: %v", err)
+			}
+		}
+		fmt.Println("Pylint configuration created based on Codacy settings")
 	}
 	return nil
 }
@@ -320,11 +333,17 @@ func createPMDConfigFile(config []domain.PatternConfiguration, toolsConfigDir st
 func createDefaultPMDConfigFile(toolsConfigDir string) error {
 	content := tools.CreatePmdConfig([]domain.PatternConfiguration{})
 	return os.WriteFile(filepath.Join(toolsConfigDir, "pmd-ruleset.xml"), []byte(content), utils.DefaultFilePerms)
+
+}
+
+func createPylintConfigFile(config []domain.PatternConfiguration, toolsConfigDir string) error {
+	pylintConfigurationString := pylint.GeneratePylintRC(config)
+	return os.WriteFile(filepath.Join(toolsConfigDir, "pylint.rc"), []byte(pylintConfigurationString), utils.DefaultFilePerms)
 }
 
-func createDefaultPylintConfigFile() error {
+func createDefaultPylintConfigFile(toolsConfigDir string) error {
 	pylintConfigurationString := pylint.GeneratePylintRCDefault()
-	return os.WriteFile(".pylintrc", []byte(pylintConfigurationString), 0644)
+	return os.WriteFile(filepath.Join(toolsConfigDir, "pylint.rc"), []byte(pylintConfigurationString), utils.DefaultFilePerms)
 }
 
 // createTrivyConfigFile creates a trivy.yaml configuration file based on the API configuration

tools/pylint/pylintConfigParser.go

@@ -1,15 +1,15 @@
 package pylint
 
 import (
-	"codacy/cli-v2/tools/types"
+	"codacy/cli-v2/domain"
 	"fmt"
 	"log"
 	"strings"
 )
 
 // getDefaultParametersForPatterns returns a map of pattern IDs to their default parameters
-func getDefaultParametersForPatterns(patternIDs []string) map[string][]types.ParameterConfiguration {
-	defaultParams := make(map[string][]types.ParameterConfiguration)
+func getDefaultParametersForPatterns(patternIDs []string) map[string][]domain.ParameterConfiguration {
+	defaultParams := make(map[string][]domain.ParameterConfiguration)
 
 	for _, patternID := range patternIDs {
 		if params, exists := PatternDefaultParameters[patternID]; exists {
@@ -39,7 +39,7 @@ func writeEnabledPatterns(rcContent *strings.Builder, patternIDs []string) {
 }
 
 // writeParametersBySection writes the parameters grouped by section to the RC content
-func writeParametersBySection(rcContent *strings.Builder, groupedParams map[string][]types.PylintPatternParameterConfiguration) {
+func writeParametersBySection(rcContent *strings.Builder, groupedParams map[string][]domain.ParameterConfiguration) {
 	for sectionName, params := range groupedParams {
 		rcContent.WriteString(fmt.Sprintf("[%s]\n", sectionName))
 		for _, param := range params {
@@ -50,30 +50,41 @@ func writeParametersBySection(rcContent *strings.Builder, groupedParams map[stri
 }
 
 // groupParametersByPatterns groups parameters from patterns into sections
-func groupParametersByPatterns(patterns []types.PatternConfiguration) map[string][]types.PylintPatternParameterConfiguration {
-	groupedParams := make(map[string][]types.PylintPatternParameterConfiguration)
+func groupParametersByPatterns(patterns []domain.PatternConfiguration) map[string][]domain.ParameterConfiguration {
+	groupedParams := make(map[string][]domain.ParameterConfiguration)
 
 	for _, pattern := range patterns {
-		patternID := extractPatternId(pattern.InternalId)
+		patternID := extractPatternId(pattern.PatternDefinition.Id)
 		params := pattern.Parameters
 
 		// If no parameters, check defaults
 		if len(params) == 0 {
-			params = PatternDefaultParameters[patternID]
+			if defaultParams, exists := PatternDefaultParameters[patternID]; exists {
+				params = defaultParams
+			}
 		}
 
+		// Add parameters to their respective sections
 		for _, param := range params {
 			sectionName := GetParameterSection(param.Name)
 			if sectionName == nil {
 				log.Printf("Parameter %s has no section name", param.Name)
 				continue
 			}
 
-			groupedParams[*sectionName] = append(groupedParams[*sectionName], types.PylintPatternParameterConfiguration{
-				Name:        param.Name,
-				Value:       param.Value,
-				SectionName: sectionName,
-			})
+			// Check if parameter already exists in section
+			exists := false
+			for _, existingParam := range groupedParams[*sectionName] {
+				if existingParam.Name == param.Name {
+					exists = true
+					break
+				}
+			}
+
+			// Only add if not already present
+			if !exists {
+				groupedParams[*sectionName] = append(groupedParams[*sectionName], param)
+			}
 		}
 	}
 
@@ -90,10 +101,12 @@ func GeneratePylintRCDefault() string {
 	defaultParams := getDefaultParametersForPatterns(DefaultPatterns)
 
 	// Convert default parameters to pattern configurations
-	var patterns []types.PatternConfiguration
+	var patterns []domain.PatternConfiguration
 	for patternID, params := range defaultParams {
-		patterns = append(patterns, types.PatternConfiguration{
-			InternalId: "PyLintPython3_" + patternID,
+		patterns = append(patterns, domain.PatternConfiguration{
+			PatternDefinition: domain.PatternDefinition{
+				Id: "PyLintPython3_" + patternID,
+			},
 			Parameters: params,
 		})
 	}
@@ -106,24 +119,23 @@ func GeneratePylintRCDefault() string {
 }
 
 // GeneratePylintRC generates a pylintrc file content with the specified patterns enabled
-func GeneratePylintRC(config types.ToolConfiguration) string {
+func GeneratePylintRC(config []domain.PatternConfiguration) string {
 	var rcContent strings.Builder
 
 	writePylintRCHeader(&rcContent)
 
 	// Collect enabled pattern IDs
 	var enabledPatternsIds []string
-	if config.IsEnabled {
-		for _, pattern := range config.Patterns {
-			patternID := extractPatternId(pattern.InternalId)
-			enabledPatternsIds = append(enabledPatternsIds, patternID)
-		}
+
+	for _, pattern := range config {
+		patternID := extractPatternId(pattern.PatternDefinition.Id)
+		enabledPatternsIds = append(enabledPatternsIds, patternID)
 	}
 
 	writeEnabledPatterns(&rcContent, enabledPatternsIds)
 
 	// Group and write parameters
-	groupedParams := groupParametersByPatterns(config.Patterns)
+	groupedParams := groupParametersByPatterns(config)
 	writeParametersBySection(&rcContent, groupedParams)
 
 	return rcContent.String()

tools/pylint/pylintDefaults.go

@@ -1,9 +1,9 @@
 package pylint
 
-import "codacy/cli-v2/tools/types"
+import "codacy/cli-v2/domain"
 
 // PatternDefaultParameters contains the default parameters for Pylint patterns
-var PatternDefaultParameters = map[string][]types.ParameterConfiguration{
+var PatternDefaultParameters = map[string][]domain.ParameterConfiguration{
 	"R0914": {
 		{
 			Name:  "max-locals",