Refactor Semgrep analysis function to return error (#76)

Updated the runSemgrepAnalysis function to return an error instead of logging fatal errors directly. This change allows for better error handling in the calling function. Additionally, cleaned up the formatting of the default versions in the config file template for improved readability.

Author: andrzej-janczak

cmd/analyze.go

@@ -222,16 +222,13 @@ func runDartAnalyzer(workDirectory string, pathsToCheck []string, outputFile str
 	return tools.RunDartAnalyzer(workDirectory, dartanalyzer.InstallDir, dartanalyzer.Binaries["dart"], pathsToCheck, outputFile, outputFormat)
 }
 
-func runSemgrepAnalysis(workDirectory string, pathsToCheck []string, outputFile string, outputFormat string) {
+func runSemgrepAnalysis(workDirectory string, pathsToCheck []string, outputFile string, outputFormat string) error {
 	semgrep := config.Config.Tools()["semgrep"]
 	if semgrep == nil {
 		log.Fatal("Semgrep tool configuration not found")
 	}
 
-	err := tools.RunSemgrep(workDirectory, semgrep, pathsToCheck, outputFile, outputFormat)
-	if err != nil {
-		log.Fatalf("Failed to run Semgrep analysis: %v", err)
-	}
+	return tools.RunSemgrep(workDirectory, semgrep, pathsToCheck, outputFile, outputFormat)
 }
 
 var analyzeCmd = &cobra.Command{
@@ -323,7 +320,7 @@ func runTool(workDirectory string, toolName string, args []string, outputFile st
 	case "pmd":
 		return runPmdAnalysis(workDirectory, args, outputFile, outputFormat)
 	case "pylint":
-        return runPylintAnalysis(workDirectory, args, outputFile, outputFormat)
+		return runPylintAnalysis(workDirectory, args, outputFile, outputFormat)
 	case "semgrep":
 		return runSemgrepAnalysis(workDirectory, args, outputFile, outputFormat)
 	case "dartanalyzer":

cmd/init.go

@@ -141,12 +141,12 @@ func configFileTemplate(tools []tools.Tool) string {
 	needsDart := false
 	// Default versions
 	defaultVersions := map[string]string{
-		ESLint:  "9.3.0",
-		Trivy:   "0.59.1",
-		PyLint:  "3.3.6",
-		PMD:     "6.55.0",
+		ESLint:       "9.3.0",
+		Trivy:        "0.59.1",
+		PyLint:       "3.3.6",
+		PMD:          "6.55.0",
 		DartAnalyzer: "3.7.2",
-		Semgrep: "1.78.0",
+		Semgrep:      "1.78.0",
 	}
 
 	// Build map of enabled tools with their versions
@@ -201,7 +201,7 @@ func configFileTemplate(tools []tools.Tool) string {
 			PyLint:       "pylint",
 			PMD:          "pmd",
 			DartAnalyzer: "dartanalyzer",
-			Semgrep: "semgrep",
+			Semgrep:      "semgrep",
 		}
 
 		for uuid, name := range uuidToName {
@@ -393,6 +393,20 @@ func createToolFileConfigurations(tool tools.Tool, patternConfiguration []domain
 			}
 		}
 		fmt.Println("Pylint configuration created based on Codacy settings")
+	case DartAnalyzer:
+		if len(patternConfiguration) > 0 {
+			err := createDartAnalyzerConfigFile(patternConfiguration, toolsConfigDir)
+			if err != nil {
+				return fmt.Errorf("failed to create Dart Analyzer config: %v", err)
+			}
+		}
+	case Semgrep:
+		if len(patternConfiguration) > 0 {
+			err := createSemgrepConfigFile(patternConfiguration, toolsConfigDir)
+			if err != nil {
+				return fmt.Errorf("failed to create Semgrep config: %v", err)
+			}
+		}
 	}
 	return nil
 }
@@ -504,5 +518,5 @@ const (
 	PMD          string = "9ed24812-b6ee-4a58-9004-0ed183c45b8f"
 	PyLint       string = "31677b6d-4ae0-4f56-8041-606a8d7a8e61"
 	DartAnalyzer string = "d203d615-6cf1-41f9-be5f-e2f660f7850f"
-	Semgrep string = "6792c561-236d-41b7-ba5e-9d6bee0d548b"
+	Semgrep      string = "6792c561-236d-41b7-ba5e-9d6bee0d548b"
 )