fix issue with initFlags when is nil

Author: DMarinhoCodacy

cmd/analyze.go

@@ -352,26 +352,32 @@ func runToolByName(toolName string, workDirectory string, pathsToCheck []string,
 		return err
 	}
 
-	// Get the tool name with the right version e.g. ESLint9, PMD7, etc.
-	toolRightVersion := getToolName(toolName, tool.Version)
-	fmt.Printf(toolName)
+	var t *domain.Tool
+	var usesConfigurationFile = false
 
-	// Get the repository tools to access tool settings
-	repositoryTools, _ := codacyclient.GetRepositoryTools(initFlags)
+	// If the user doesn't provide init flags, we skip fetching repository tools
+	if initFlags != (domain.InitFlags{}) {
+		// Get the tool name with the right version e.g. ESLint9, PMD7, etc.
+		toolRightVersion := getToolName(toolName, tool.Version)
 
-	// Find the matching tool in repositoryTools
-	var t *domain.Tool
-	for i, tool := range repositoryTools {
-		if tool.Name == toolRightVersion {
-			t = &repositoryTools[i]
-			break
+		// Get the repository tools to access tool settings
+		repositoryTools, _ := codacyclient.GetRepositoryTools(initFlags)
+
+		// Find the matching tool in repositoryTools
+
+		for i, tool := range repositoryTools {
+			if tool.Name == toolRightVersion {
+				t = &repositoryTools[i]
+				usesConfigurationFile = t.Settings.UsesConfigurationFile
+				break
+			}
 		}
 	}
 
 	switch toolName {
 	case "eslint":
 		binaryPath := runtime.Binaries[tool.Runtime]
-		return tools.RunEslint(workDirectory, tool.InstallDir, binaryPath, pathsToCheck, autoFix, outputFile, outputFormat, t.Settings.UsesConfigurationFile)
+		return tools.RunEslint(workDirectory, tool.InstallDir, binaryPath, pathsToCheck, autoFix, outputFile, outputFormat, usesConfigurationFile)
 	case "trivy":
 		binaryPath := tool.Binaries[toolName]
 		return tools.RunTrivy(workDirectory, binaryPath, pathsToCheck, outputFile, outputFormat)

tools/eslintRunner.go

@@ -11,14 +11,14 @@ import (
 // * Run from the root of the repo we want to analyse
 // * NODE_PATH="<the installed eslint path>/node_modules"
 // * The local installed ESLint should have the @microsoft/eslint-formatter-sarif installed
-func RunEslint(repositoryToAnalyseDirectory string, eslintInstallationDirectory string, nodeBinary string, pathsToCheck []string, autoFix bool, outputFile string, outputFormat string, UsesConfigurationFile bool) error {
+func RunEslint(repositoryToAnalyseDirectory string, eslintInstallationDirectory string, nodeBinary string, pathsToCheck []string, autoFix bool, outputFile string, outputFormat string, usesConfigurationFile bool) error {
 	eslintInstallationNodeModules := filepath.Join(eslintInstallationDirectory, "node_modules")
 	eslintJsPath := filepath.Join(eslintInstallationNodeModules, ".bin", "eslint")
 
 	cmd := exec.Command(nodeBinary, eslintJsPath)
 
 	// Add config file from tools-configs directory if it exists
-	if !UsesConfigurationFile {
+	if !usesConfigurationFile {
 		if configFile, exists := ConfigFileExists(config.Config, "eslint.config.mjs"); exists {
 			// For Eslint compatibility with version 8.
 			// https://eslint.org/docs/v8.x/use/configure/configuration-files-new

tools/runnerUtils.go

@@ -21,10 +21,10 @@ func ConfigFileExists(conf config.ConfigType, fileNames ...string) (string, bool
 		generatedConfigFile := filepath.Join(conf.ToolsConfigDirectory(), fileName)
 		existingConfigFile := filepath.Join(conf.RepositoryDirectory(), fileName)
 
-		if _, err := os.Stat(generatedConfigFile); err == nil {
-			return generatedConfigFile, true
-		} else if _, err := os.Stat(existingConfigFile); err == nil {
+		if _, err := os.Stat(existingConfigFile); err == nil {
 			return existingConfigFile, true
+		} else if _, err := os.Stat(generatedConfigFile); err == nil {
+			return generatedConfigFile, true
 		}
 	}