fix: Only pass configuration file if created, otherwise fallback to native tool PLUTO-1383

Still needs updates on PMD

Author: machadoit

tools/eslintRunner.go

@@ -1,7 +1,6 @@
 package tools
 
 import (
-	"codacy/cli-v2/config"
 	"os"
 	"os/exec"
 	"path/filepath"
@@ -20,9 +19,10 @@ func RunEslint(repositoryToAnalyseDirectory string, eslintInstallationDirectory
 	// https://eslint.org/docs/v8.x/use/configure/configuration-files-new
 	cmd.Env = append(cmd.Env, "ESLINT_USE_FLAT_CONFIG=true")
 
-	// Add config file from tools-configs directory
-	configFile := filepath.Join(config.Config.ToolsConfigDirectory(), "eslint.config.mjs")
-	cmd.Args = append(cmd.Args, "-c", configFile)
+	// Add config file from tools-configs directory if it exists
+	if configFile, exists := ConfigFileExists(repositoryToAnalyseDirectory, "eslint.config.mjs"); exists {
+		cmd.Args = append(cmd.Args, "-c", configFile)
+	}
 
 	if autoFix {
 		cmd.Args = append(cmd.Args, "--fix")

tools/pmdRunner.go

@@ -25,6 +25,7 @@ func RunPmd(repositoryToAnalyseDirectory string, pmdBinary string, pathsToCheck
 
 	// Add config file from tools-configs directory if not specified
 	if rulesetFile == "" {
+		// TODO: Check if the config file exists before using it
 		configFile := filepath.Join(config.Config.ToolsConfigDirectory(), "pmd-ruleset.xml")
 		cmd.Args = append(cmd.Args, "-R", configFile)
 	} else {

tools/pylintRunner.go

@@ -19,9 +19,10 @@ func RunPylint(workDirectory string, toolInfo *plugins.ToolInfo, files []string,
 	// Always use JSON output format since we'll convert to SARIF if needed
 	args = append(args, "--output-format=json")
 
-	// Use the configuration file from .codacy/tools-configs/pylintrc
-	configPath := filepath.Join(workDirectory, ".codacy", "tools-configs", "pylint.rc")
-	args = append(args, fmt.Sprintf("--rcfile=%s", configPath))
+	// Check if a config file exists in the expected location and use it if present
+	if configFile, exists := ConfigFileExists(workDirectory, "pylint.rc"); exists {
+		args = append(args, fmt.Sprintf("--rcfile=%s", configFile))
+	}
 
 	// Create a temporary file for JSON output if we need to convert to SARIF
 	var tempFile string

tools/runnerUtils.go

@@ -0,0 +1,27 @@
+package tools
+
+import (
+	"os"
+	"path/filepath"
+)
+
+// ConfigFileExists checks if a specific configuration file exists in the .codacy/tools-configs/ directory
+// of the specified repository.
+//
+// Parameters:
+//   - repositoryDir: The repository directory path
+//   - fileName: The configuration file name to check for
+//
+// Returns:
+//   - string: The relative path to the configuration file (for cmd args)
+//   - bool: True if the file exists, false otherwise
+func ConfigFileExists(repositoryDir string, fileName string) (string, bool) {
+	configFile := filepath.Join(".codacy", "tools-configs", fileName)
+	configFilePath := filepath.Join(repositoryDir, configFile)
+
+	if _, err := os.Stat(configFilePath); err == nil {
+		return configFile, true
+	}
+
+	return "", false
+}

tools/runnerUtils_test.go

@@ -0,0 +1,36 @@
+package tools
+
+import (
+	"os"
+	"path/filepath"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestConfigFileExists(t *testing.T) {
+	// Create a test directory structure
+	tempDir := t.TempDir()
+
+	// Create .codacy/tools-configs directory
+	configDir := filepath.Join(tempDir, ".codacy", "tools-configs")
+
+	err := os.MkdirAll(configDir, 0755)
+	assert.NoError(t, err, "Failed to create test directory structure")
+
+	// Create a test config file
+	testConfigFile := filepath.Join(configDir, "test-config.yaml")
+	err = os.WriteFile(testConfigFile, []byte("test content"), 0644)
+	assert.NoError(t, err, "Failed to create test config file")
+
+	// Test case 1: Config file exists
+	configPath, exists := ConfigFileExists(tempDir, "test-config.yaml")
+	assert.True(t, exists, "Config file should exist")
+	assert.Equal(t, filepath.Join(".codacy", "tools-configs", "test-config.yaml"), configPath,
+		"Config path should be correctly formed relative path")
+
+	// Test case 2: Config file doesn't exist
+	configPath, exists = ConfigFileExists(tempDir, "non-existent-config.yaml")
+	assert.False(t, exists, "Config file should not exist")
+	assert.Equal(t, "", configPath, "Config path should be empty for non-existent file")
+}

tools/trivyRunner.go

@@ -1,19 +1,18 @@
 package tools
 
 import (
-	"codacy/cli-v2/config"
 	"os"
 	"os/exec"
-	"path/filepath"
 )
 
 // RunTrivy executes Trivy vulnerability scanner with the specified options
 func RunTrivy(repositoryToAnalyseDirectory string, trivyBinary string, pathsToCheck []string, outputFile string, outputFormat string) error {
 	cmd := exec.Command(trivyBinary, "fs")
 
-	// Add config file from tools-configs directory
-	configFile := filepath.Join(config.Config.ToolsConfigDirectory(), "trivy.yaml")
-	cmd.Args = append(cmd.Args, "--config", configFile)
+	// Add config file from tools-configs directory if it exists
+	if configFile, exists := ConfigFileExists(repositoryToAnalyseDirectory, "trivy.yaml"); exists {
+		cmd.Args = append(cmd.Args, "--config", configFile)
+	}
 
 	// Add format options
 	if outputFile != "" {