removed extra prints on downloading runtimes

Author: franciscoovazevedo

cmd/analyze.go

@@ -300,7 +300,7 @@ func genericRunTool(toolName string, workDirectory string, pathsToCheck []string
 		runtime = config.Config.Runtimes()[tool.Runtime]
 		isRuntimeInstalled = runtime == nil || config.Config.IsRuntimeInstalled(tool.Runtime, runtime)
 		if !isRuntimeInstalled {
-			fmt.Println("Runtime is not installed, installing...")
+			fmt.Printf("%s runtime is not installed, installing...\n", tool.Runtime)
 			err := config.InstallRuntime(tool.Runtime, runtime)
 			if err != nil {
 				return fmt.Errorf("failed to install %s runtime: %w", tool.Runtime, err)
@@ -312,7 +312,7 @@ func genericRunTool(toolName string, workDirectory string, pathsToCheck []string
 		runtime = config.Config.Runtimes()[tool.Runtime]
 		isRuntimeInstalled = runtime == nil || config.Config.IsRuntimeInstalled(tool.Runtime, runtime)
 		if !isRuntimeInstalled {
-			fmt.Println("Runtime is not installed, installing...")
+			fmt.Printf("%s runtime is not installed, installing...\n", tool.Runtime)
 			err := config.InstallRuntime(tool.Runtime, runtime)
 			if err != nil {
 				return fmt.Errorf("failed to install %s runtime: %w", tool.Runtime, err)

config/runtimes-installer.go

@@ -48,13 +48,11 @@ func InstallRuntimes(config *ConfigType) error {
 // InstallRuntime installs a specific runtime
 func InstallRuntime(name string, runtimeInfo *plugins.RuntimeInfo) error {
 	// Skip if already installed
-	fmt.Printf("Checking if runtime %s v%s is installed\n", name, runtimeInfo.Version)
 	if Config.IsRuntimeInstalled(name, runtimeInfo) {
 		logger.Info("Runtime already installed", logrus.Fields{
 			"runtime": name,
 			"version": runtimeInfo.Version,
 		})
-		fmt.Printf("Runtime %s v%s is already installed\n", name, runtimeInfo.Version)
 		return nil
 	}
 

utils/download.go

@@ -1,28 +1,38 @@
 package utils
 
 import (
+	"codacy/cli-v2/utils/logger"
 	"fmt"
 	"io"
-	"log"
 	"net/http"
 	"os"
 	"path/filepath"
+
+	"github.com/sirupsen/logrus"
 )
 
 func DownloadFile(url string, destDir string) (string, error) {
-	log.Printf("Attempting to download from URL: %s", url)
+	logger.Debug("Attempting to download from URL", logrus.Fields{
+		"url": url,
+	})
 
 	// Get the file name from the URL
 	fileName := filepath.Base(url)
-	log.Printf("Target filename: %s", fileName)
+	logger.Debug("Target filename determined", logrus.Fields{
+		"fileName": fileName,
+	})
 
 	// Create the destination file path
 	destPath := filepath.Join(destDir, fileName)
-	log.Printf("Destination path: %s", destPath)
+	logger.Debug("Destination path set", logrus.Fields{
+		"destPath": destPath,
+	})
 
 	_, errInfo := os.Stat(destPath)
 	if errInfo != nil && os.IsExist(errInfo) {
-		log.Printf("File already exists at destination, skipping download")
+		logger.Debug("File already exists at destination, skipping download", logrus.Fields{
+			"destPath": destPath,
+		})
 		return destPath, nil
 	}
 
@@ -34,7 +44,9 @@ func DownloadFile(url string, destDir string) (string, error) {
 	defer outFile.Close()
 
 	// Make the HTTP GET request
-	log.Printf("Making HTTP GET request...")
+	logger.Debug("Making HTTP GET request", logrus.Fields{
+		"url": url,
+	})
 	client := &http.Client{}
 	req, err := http.NewRequest("GET", url, nil)
 	if err != nil {
@@ -54,12 +66,14 @@ func DownloadFile(url string, destDir string) (string, error) {
 	}
 
 	// Copy the response body to the destination file
-	log.Printf("Downloading file content...")
+	logger.Debug("Downloading file content")
 	written, err := io.Copy(outFile, resp.Body)
 	if err != nil {
 		return "", fmt.Errorf("failed to copy file contents: %w", err)
 	}
-	log.Printf("Downloaded %d bytes", written)
+	logger.Debug("Downloaded file successfully", logrus.Fields{
+		"bytes": written,
+	})
 
 	if written == 0 {
 		return "", fmt.Errorf("downloaded file is empty (0 bytes)")