fix: capture error exit code for pmd

Author: andrzej-janczak

cmd/analyze.go

@@ -9,7 +9,6 @@ import (
 	"log"
 	"net/http"
 	"os"
-	"os/exec"
 
 	"github.com/spf13/cobra"
 )
@@ -210,32 +209,7 @@ func runPmdAnalysis(workDirectory string, pathsToCheck []string, outputFile stri
 	pmd := config.Config.Tools()["pmd"]
 	pmdBinary := pmd.Binaries["pmd"]
 
-	// Build PMD command arguments
-	args := []string{"check"}
-
-	// Add ruleset file if provided
-	if pmdRulesetFile != "" {
-		args = append(args, "--rulesets", pmdRulesetFile)
-	}
-
-	// Add format options
-	if outputFormat == "sarif" {
-		args = append(args, "--format", "sarif")
-	}
-
-	if outputFile != "" {
-		args = append(args, "--report-file", outputFile)
-	}
-
-	// Add directory to scan
-	args = append(args, "--dir", workDirectory)
-
-	cmd := exec.Command(pmdBinary, args...)
-	cmd.Dir = workDirectory
-	cmd.Stderr = os.Stderr
-	cmd.Stdout = os.Stdout
-
-	err := cmd.Run()
+	err := tools.RunPmd(workDirectory, pmdBinary, pathsToCheck, outputFile, outputFormat, pmdRulesetFile)
 	if err != nil {
 		log.Fatalf("Error running PMD: %v", err)
 	}

tools/pmdRunner.go

@@ -23,16 +23,20 @@ func RunPmd(repositoryToAnalyseDirectory string, pmdBinary string, pathsToCheck
 		cmd.Args = append(cmd.Args, "--report-file", outputFile)
 	}
 
-	// Add specific targets or use current directory
-	if len(pathsToCheck) > 0 {
-		cmd.Args = append(cmd.Args, pathsToCheck...)
-	} else {
-		cmd.Args = append(cmd.Args, ".")
-	}
+	// Add directory to scan
+	cmd.Args = append(cmd.Args, "--dir", repositoryToAnalyseDirectory)
 
 	cmd.Dir = repositoryToAnalyseDirectory
 	cmd.Stderr = os.Stderr
 	cmd.Stdout = os.Stdout
 
-	return cmd.Run()
+	err := cmd.Run()
+	if err != nil {
+		if exitErr, ok := err.(*exec.ExitError); ok && exitErr.ExitCode() == 4 {
+			// Exit status 4 means violations were found, which is not an error
+			return nil
+		}
+		return err
+	}
+	return nil
 }