Skip to content

Commit 371ffe3

Browse files
committed
add consistency to Run tool
1 parent 3c0e751 commit 371ffe3

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

cmd/analyze.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,10 @@ func runPylintAnalysis(workDirectory string, pathsToCheck []string, outputFile s
228228

229229
func runDartAnalyzer(workDirectory string, pathsToCheck []string, outputFile string, outputFormat string) {
230230
dartanalyzer := config.Config.Tools()["dartanalyzer"]
231-
tools.RunDartAnalyzer(workDirectory, dartanalyzer.InstallDir, dartanalyzer.Binaries["dart"], pathsToCheck, outputFile, outputFormat)
231+
err := tools.RunDartAnalyzer(workDirectory, dartanalyzer.InstallDir, dartanalyzer.Binaries["dart"], pathsToCheck, outputFile, outputFormat)
232+
if err != nil {
233+
log.Fatalf("Error running Dart Analyzer: %v", err)
234+
}
232235
}
233236

234237
var analyzeCmd = &cobra.Command{

tools/dartanalyzerRunner.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import (
1414

1515
const patternPrefix = "dartanalyzer_"
1616

17-
func RunDartAnalyzer(workDirectory string, installationDirectory string, binary string, files []string, outputFile string, outputFormat string) {
17+
func RunDartAnalyzer(workDirectory string, installationDirectory string, binary string, files []string, outputFile string, outputFormat string) error {
1818

1919
configFiles := []string{"analysis_options.yaml", "analysis_options.yml"}
2020
dartAnalyzerPath := filepath.Join(installationDirectory, "bin", "dart")
@@ -128,5 +128,5 @@ func RunDartAnalyzer(workDirectory string, installationDirectory string, binary
128128
cmd.Stdout = os.Stdout
129129
cmd.Run()
130130
}
131-
131+
return nil
132132
}

0 commit comments

Comments
 (0)