added test

Author: franciscoovazevedo

cmd/analyze_integration_test.go

@@ -0,0 +1,170 @@
+package cmd
+
+import (
+	"path/filepath"
+	"strings"
+	"testing"
+
+	"codacy/cli-v2/config"
+	"codacy/cli-v2/domain"
+
+	"github.com/stretchr/testify/assert"
+)
+
+// TestCheckIfConfigExistsAndIsNeededBehavior tests the behavior of checkIfConfigExistsAndIsNeeded
+func TestCheckIfConfigExistsAndIsNeededBehavior(t *testing.T) {
+	// Save original state
+	originalFlags := initFlags
+	defer func() {
+		initFlags = originalFlags
+	}()
+
+	tests := []struct {
+		name          string
+		toolName      string
+		cliLocalMode  bool
+		apiToken      string
+		description   string
+		expectNoError bool
+	}{
+		{
+			name:          "tool_without_config_file",
+			toolName:      "unsupported-tool",
+			cliLocalMode:  false,
+			apiToken:      "test-token",
+			description:   "Tool that doesn't use config files should return without error",
+			expectNoError: true,
+		},
+		{
+			name:          "eslint_remote_mode_with_token",
+			toolName:      "eslint",
+			cliLocalMode:  false,
+			apiToken:      "test-token",
+			description:   "ESLint in remote mode with token should not error",
+			expectNoError: true,
+		},
+		{
+			name:          "eslint_remote_mode_without_token",
+			toolName:      "eslint",
+			cliLocalMode:  false,
+			apiToken:      "",
+			description:   "ESLint in remote mode without token should not error",
+			expectNoError: true,
+		},
+		{
+			name:          "eslint_local_mode",
+			toolName:      "eslint",
+			cliLocalMode:  true,
+			apiToken:      "",
+			description:   "ESLint in local mode should not error",
+			expectNoError: true,
+		},
+		{
+			name:          "trivy_local_mode",
+			toolName:      "trivy",
+			cliLocalMode:  true,
+			apiToken:      "",
+			description:   "Trivy in local mode should not error",
+			expectNoError: true,
+		},
+		{
+			name:          "pmd_remote_mode",
+			toolName:      "pmd",
+			cliLocalMode:  false,
+			apiToken:      "test-token",
+			description:   "PMD in remote mode should not error",
+			expectNoError: true,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			// Setup initFlags
+			initFlags = domain.InitFlags{
+				ApiToken: tt.apiToken,
+			}
+
+			// Execute the function - this tests it doesn't panic or return unexpected errors
+			err := checkIfConfigExistsAndIsNeeded(tt.toolName, tt.cliLocalMode)
+
+			// Verify results
+			if tt.expectNoError {
+				assert.NoError(t, err, "Function should not return error: %s", tt.description)
+			} else {
+				assert.Error(t, err, "Function should return error: %s", tt.description)
+			}
+		})
+	}
+}
+
+// TestToolConfigFileNameMapCompleteness ensures all expected tools have config mappings
+func TestToolConfigFileNameMapCompleteness(t *testing.T) {
+	expectedTools := map[string]string{
+		"eslint":       "eslint.config.mjs",
+		"trivy":        "trivy.yaml",
+		"pmd":          "ruleset.xml",
+		"pylint":       "pylint.rc",
+		"dartanalyzer": "analysis_options.yaml",
+		"semgrep":      "semgrep.yaml",
+		"revive":       "revive.toml",
+		"lizard":       "lizard.yaml",
+	}
+
+	t.Run("all_expected_tools_present", func(t *testing.T) {
+		for toolName, expectedFileName := range expectedTools {
+			actualFileName, exists := toolConfigFileName[toolName]
+			assert.True(t, exists, "Tool %s should exist in toolConfigFileName map", toolName)
+			assert.Equal(t, expectedFileName, actualFileName, "Config filename for %s should match expected", toolName)
+		}
+	})
+
+	t.Run("no_unexpected_tools", func(t *testing.T) {
+		for toolName := range toolConfigFileName {
+			_, expected := expectedTools[toolName]
+			assert.True(t, expected, "Unexpected tool %s found in toolConfigFileName map", toolName)
+		}
+	})
+
+	t.Run("config_files_have_proper_extensions", func(t *testing.T) {
+		validExtensions := map[string]bool{
+			".mjs":  true,
+			".js":   true,
+			".yaml": true,
+			".yml":  true,
+			".xml":  true,
+			".rc":   true,
+			".toml": true,
+		}
+
+		for toolName, fileName := range toolConfigFileName {
+			ext := filepath.Ext(fileName)
+			assert.True(t, validExtensions[ext], "Tool %s has config file %s with unexpected extension %s", toolName, fileName, ext)
+		}
+	})
+}
+
+// TestCheckIfConfigExistsAndIsNeededEdgeCases tests edge cases and error conditions
+func TestCheckIfConfigExistsAndIsNeededEdgeCases(t *testing.T) {
+	originalFlags := initFlags
+	originalConfig := config.Config
+	defer func() {
+		initFlags = originalFlags
+		config.Config = originalConfig
+	}()
+
+	t.Run("empty_tool_name", func(t *testing.T) {
+		err := checkIfConfigExistsAndIsNeeded("", false)
+		assert.NoError(t, err, "Empty tool name should not cause error")
+	})
+
+	t.Run("tool_name_with_special_characters", func(t *testing.T) {
+		err := checkIfConfigExistsAndIsNeeded("tool-with-dashes_and_underscores", false)
+		assert.NoError(t, err, "Tool name with special characters should not cause error")
+	})
+
+	t.Run("very_long_tool_name", func(t *testing.T) {
+		longToolName := strings.Repeat("verylongtoolname", 10)
+		err := checkIfConfigExistsAndIsNeeded(longToolName, false)
+		assert.NoError(t, err, "Very long tool name should not cause error")
+	})
+}

cmd/analyze_test.go

@@ -384,28 +384,3 @@ func TestToolConfigFileNameMap(t *testing.T) {
 		})
 	}
 }
-
-func TestGetFileExtension(t *testing.T) {
-	tests := []struct {
-		filePath string
-		expected string
-	}{
-		{"test.js", ".js"},
-		{"test.jsx", ".jsx"},
-		{"test.ts", ".ts"},
-		{"test.tsx", ".tsx"},
-		{"test.py", ".py"},
-		{"test.java", ".java"},
-		{"test", ""},
-		{"test.JS", ".js"}, // Should be lowercase
-		{"/path/to/test.py", ".py"},
-		{"", ""},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.filePath, func(t *testing.T) {
-			result := GetFileExtension(tt.filePath)
-			assert.Equal(t, tt.expected, result)
-		})
-	}
-}