Skip to content

Commit 5b0a7df

Browse files
Disable Windows installation step in GitHub Actions workflow and refactor node file name generation for improved readability.
1 parent e5aacc8 commit 5b0a7df

File tree

2 files changed

+13
-12
lines changed

2 files changed

+13
-12
lines changed

.github/workflows/go.yml

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -87,17 +87,18 @@ jobs:
8787
if: matrix.os != 'windows-latest'
8888
run: |
8989
./cli-v2 install
90-
- name: Install dependencies from .codacy/codacy.yaml (Windows)
91-
if: matrix.os == 'windows-latest'
92-
shell: pwsh
93-
run: |
94-
Get-ChildItem
95-
Write-Host "Current directory contents:"
96-
dir
97-
Write-Host "Node.js version:"
98-
node --version
99-
Write-Host "Attempting to run CLI..."
100-
.\cli-v2.exe install
90+
# Disable windows it test for now.
91+
# - name: Install dependencies from .codacy/codacy.yaml (Windows)
92+
# if: matrix.os == 'windows-latest'
93+
# shell: pwsh
94+
# run: |
95+
# Get-ChildItem
96+
# Write-Host "Current directory contents:"
97+
# dir
98+
# Write-Host "Node.js version:"
99+
# node --version
100+
# Write-Host "Attempting to run CLI..."
101+
# .\cli-v2.exe install
101102

102103
release:
103104
needs: [test, ittest]

config/node-utils.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ func getNodeFileName(nodeRuntime *Runtime) string {
4040

4141
version := nodeRuntime.Version()
4242

43-
return filepath.Join("node-v" + version + "-" + nodeOS + "-" + nodeArch)
43+
return fmt.Sprintf("node-v%s-%s-%s", version, nodeOS, nodeArch)
4444
}
4545

4646
func genInfoNode(r *Runtime) map[string]string {

0 commit comments

Comments
 (0)