Merge pull request #83 from codacy/not-processing-eslint-plugins

avoiding eslint plugins - PLUTO-1364

Author: franciscoovazevedo

cmd/init.go

@@ -342,7 +342,7 @@ func createToolFileConfigurations(tool tools.Tool, patternConfiguration []domain
 			if err != nil {
 				return fmt.Errorf("failed to write eslint config: %v", err)
 			}
-			fmt.Println("ESLint configuration created based on Codacy settings")
+			fmt.Println("ESLint configuration created based on Codacy settings. Ignoring plugin rules. ESLint plugins are not supported yet.")
 		} else {
 			err := createDefaultEslintConfigFile(toolsConfigDir)
 			if err != nil {

tools/eslintConfigCreator.go

@@ -28,10 +28,28 @@ func CreateEslintConfig(configuration []domain.PatternConfiguration) string {
 	for _, patternConfiguration := range configuration {
 		rule := strings.TrimPrefix(patternConfiguration.PatternDefinition.Id, "ESLint8_")
 
-		const tempstring = "TEMPORARYSTRING"
-		rule = strings.ReplaceAll(rule, "__", tempstring)
-		rule = strings.ReplaceAll(rule, "_", "/")
-		rule = strings.ReplaceAll(rule, tempstring, "_")
+		// Handle plugin rules (those containing _)
+		if strings.Contains(rule, "_") {
+			parts := strings.Split(rule, "_")
+			if len(parts) >= 2 {
+				// First part is the plugin name, last part is the rule name
+				plugin := parts[0]
+				ruleName := parts[len(parts)-1]
+
+				// Handle scoped packages
+				if strings.HasPrefix(plugin, "@") {
+					rule = fmt.Sprintf("%s/%s", plugin, ruleName)
+				} else {
+					// For non-scoped packages, add eslint-plugin- prefix
+					rule = fmt.Sprintf("%s/%s", "eslint-plugin-"+plugin, ruleName)
+				}
+			}
+		}
+
+		// Skip any rule that contains a plugin (contains "/")
+		if strings.Contains(rule, "/") {
+			continue
+		}
 
 		parametersString := ""
 
@@ -44,7 +62,6 @@ func CreateEslintConfig(configuration []domain.PatternConfiguration) string {
 		// build named parameters json object
 		namedParametersString := ""
 		for _, parameter := range patternConfiguration.Parameters {
-
 			if parameter.Name != "unnamedParam" {
 				if len(namedParametersString) == 0 {
 					namedParametersString += "{"

tools/eslintConfigCreator_test.go

@@ -70,7 +70,7 @@ func TestCreateEslintConfigNamedParam(t *testing.T) {
 		[]domain.PatternConfiguration{
 			{
 				PatternDefinition: domain.PatternDefinition{
-					Id: "consistent-return",
+					Id: "ESLint8_consistent-return",
 				},
 				Parameters: []domain.ParameterConfiguration{
 					{
@@ -94,7 +94,7 @@ func TestCreateEslintConfigUnnamedAndNamedParam(t *testing.T) {
 		[]domain.PatternConfiguration{
 			{
 				PatternDefinition: domain.PatternDefinition{
-					Id: "consistent-return",
+					Id: "ESLint8_consistent-return",
 				},
 				Parameters: []domain.ParameterConfiguration{
 					{
@@ -117,19 +117,18 @@ func TestCreateEslintConfigUnnamedAndNamedParam(t *testing.T) {
 ];`)
 }
 
-func TestCreateEslintConfigSupportPlugins(t *testing.T) {
+func TestCreateEslintConfigDoNotSupportPlugins(t *testing.T) {
 	testConfig(t,
 		[]domain.PatternConfiguration{
 			{
 				PatternDefinition: domain.PatternDefinition{
-					Id: "plugin/consistent-return",
+					Id: "ESLint8_plugin_consistent-return",
 				},
 			},
 		},
 		`export default [
     {
         rules: {
-          "plugin/consistent-return": "error",
         }
     }
 ];`)