refactor: Use constants for file and directory permissions in tool runners

- Updated file and directory permission settings in tools (Dart Analyzer, Pylint, Lizard) to utilize constants from the new constants package.
- Ensured consistent permission handling across various tool runners, enhancing maintainability and readability of the codebase.

Author: andrzej-janczak

config/tools-installer.go

@@ -2,6 +2,7 @@ package config
 
 import (
 	"bytes"
+	"codacy/cli-v2/constants"
 	"codacy/cli-v2/plugins"
 	"codacy/cli-v2/utils"
 	"codacy/cli-v2/utils/logger"
@@ -102,7 +103,7 @@ func InstallTool(name string, toolInfo *plugins.ToolInfo, registry string) error
 	}
 
 	// Make sure the installation directory exists
-	err := os.MkdirAll(toolInfo.InstallDir, 0755)
+	err := os.MkdirAll(toolInfo.InstallDir, constants.DefaultDirPerms)
 	if err != nil {
 		return fmt.Errorf("failed to create installation directory: %w", err)
 	}
@@ -291,7 +292,7 @@ func installDownloadBasedTool(toolInfo *plugins.ToolInfo) error {
 	defer file.Close()
 
 	// Create the installation directory
-	err = os.MkdirAll(toolInfo.InstallDir, 0755)
+	err = os.MkdirAll(toolInfo.InstallDir, constants.DefaultDirPerms)
 	if err != nil {
 		return fmt.Errorf("failed to create installation directory: %w", err)
 	}
@@ -316,7 +317,7 @@ func installDownloadBasedTool(toolInfo *plugins.ToolInfo) error {
 
 	// Make sure all binaries are executable
 	for _, binaryPath := range toolInfo.Binaries {
-		err = os.Chmod(filepath.Join(toolInfo.InstallDir, filepath.Base(binaryPath)), 0755)
+		err = os.Chmod(filepath.Join(toolInfo.InstallDir, filepath.Base(binaryPath)), constants.DefaultDirPerms)
 		if err != nil && !os.IsNotExist(err) {
 			return fmt.Errorf("failed to make binary executable: %w", err)
 		}

tools/dartanalyzerRunner.go

@@ -3,6 +3,7 @@ package tools
 import (
 	"bufio"
 	"bytes"
+	"codacy/cli-v2/constants"
 	"encoding/json"
 	"fmt"
 	"log"
@@ -121,7 +122,7 @@ func RunDartAnalyzer(workDirectory string, installationDirectory string, binary
 		// Write SARIF output to file if specified
 		if outputFile != "" {
 			sarifJson, _ := json.MarshalIndent(sarif, "", "  ")
-			err := os.WriteFile(outputFile, sarifJson, 0644)
+			err := os.WriteFile(outputFile, sarifJson, constants.DefaultFilePerms)
 			if err != nil {
 				fmt.Fprintf(os.Stderr, "Error writing SARIF output: %v\n", err)
 			}

tools/lizard/lizardRunner.go

@@ -3,6 +3,7 @@ package lizard
 import (
 	"bytes"
 	"codacy/cli-v2/config"
+	"codacy/cli-v2/constants"
 	"codacy/cli-v2/domain"
 	"codacy/cli-v2/tools"
 	"encoding/json"
@@ -84,7 +85,7 @@ func RunLizard(workDirectory string, binary string, files []string, outputFile s
 
 				// Write SARIF output to file if specified, else stdout
 				if outputFile != "" {
-					err = os.WriteFile(outputFile, sarifData, 0644)
+					err = os.WriteFile(outputFile, sarifData, constants.DefaultFilePerms)
 					if err != nil {
 						return fmt.Errorf("failed to write SARIF output: %w", err)
 					}

tools/pylintRunner.go

@@ -2,6 +2,7 @@ package tools
 
 import (
 	"codacy/cli-v2/config"
+	"codacy/cli-v2/constants"
 	"codacy/cli-v2/utils"
 	"fmt"
 	"os"
@@ -69,7 +70,7 @@ func RunPylint(workDirectory string, binary string, files []string, outputFile s
 		sarifOutput := utils.ConvertPylintToSarif(jsonOutput)
 
 		if outputFile != "" {
-			err = os.WriteFile(outputFile, sarifOutput, 0644)
+			err = os.WriteFile(outputFile, sarifOutput, constants.DefaultFilePerms)
 			if err != nil {
 				return fmt.Errorf("failed to write SARIF output: %w", err)
 			}