wip duncan support no sarif

Author: kendrickcurtis

cmd/analyze.go

@@ -359,6 +359,9 @@ func runToolByName(toolName string, workDirectory string, pathsToCheck []string,
 		return tools.RunEnigma(workDirectory, tool.InstallDir, tool.Binaries["codacy-enigma-cli"], pathsToCheck, outputFile, outputFormat)
 	case "revive":
 		return reviveTool.RunRevive(workDirectory, tool.Binaries["revive"], pathsToCheck, outputFile, outputFormat)
+	case "license-sim":
+		binaryPath := tool.Binaries["duncan"]
+		return tools.RunLicenseSim(workDirectory, binaryPath, pathsToCheck, outputFile, outputFormat)
 	}
 	return fmt.Errorf("unsupported tool: %s", toolName)
 }

config/tools-installer.go

@@ -92,6 +92,15 @@ func InstallTool(name string, toolInfo *plugins.ToolInfo, registry string) error
 		isRuntimeInstalled = true
 	}
 
+	// Skip installation for local binary tools (no runtime, no download URL)
+	if toolInfo.Runtime == "" && toolInfo.DownloadURL == "" {
+		logger.Info("Skipping installation for local binary tool", logrus.Fields{
+			"tool":    name,
+			"version": toolInfo.Version,
+		})
+		return nil
+	}
+
 	if isToolInstalled && isRuntimeInstalled {
 		logger.Info("Tool and runtime already installed", logrus.Fields{
 			"tool":    name,

plugins/tool-utils.go

@@ -154,6 +154,14 @@ func ProcessTools(configs []ToolConfig, toolDir string, runtimes map[string]*Run
 			Environment: make(map[string]string),
 		}
 
+		// If toolRuntime is empty, set safe defaults for binary-only tools
+		if toolRuntime == "" {
+			info.PackageManager = ""
+			info.ExecutionBinary = ""
+			info.InstallCommand = ""
+			info.RegistryCommand = ""
+		}
+
 		// Handle download configuration for directly downloaded tools
 		if pluginConfig.Download.URLTemplate != "" {
 			// Get the mapped architecture
@@ -226,6 +234,12 @@ func ProcessTools(configs []ToolConfig, toolDir string, runtimes map[string]*Run
 			}
 
 			var buf bytes.Buffer
+			var runtimeInstallDir string
+			if toolRuntime != "" && runtimes != nil && runtimes[toolRuntime] != nil {
+				runtimeInstallDir = runtimes[toolRuntime].InstallDir
+			} else {
+				runtimeInstallDir = ""
+			}
 			err = tmpl.Execute(&buf, struct {
 				Version           string
 				InstallDir        string
@@ -234,7 +248,7 @@ func ProcessTools(configs []ToolConfig, toolDir string, runtimes map[string]*Run
 			}{
 				Version:           config.Version,
 				InstallDir:        installDir,
-				RuntimeInstallDir: runtimes[toolRuntime].InstallDir,
+				RuntimeInstallDir: runtimeInstallDir,
 				Path:              os.Getenv("PATH"),
 			})
 			if err != nil {

plugins/tool-utils_test.go

@@ -171,6 +171,7 @@ func TestGetSupportedTools(t *testing.T) {
 				"lizard",
 				"codacy-enigma-cli",
 				"revive",
+				"license-sim",
 			},
 			expectedError: false,
 		},

plugins/tools/license-sim/plugin.yaml

@@ -0,0 +1,9 @@
+name: license-sim
+description: Detects GPL and other licenses in code using ML similarity.
+default_version: "local"
+# This is a local binary tool; venv must be set up manually in ../license-sim/venv
+environment:
+  KMP_DUPLICATE_LIB_OK: "TRUE"
+binaries:
+  - name: duncan
+    path: "/Users/kendrickcurtis/Documents/GitHub/license-sim/venv/bin/python /Users/kendrickcurtis/Documents/GitHub/license-sim/duncan.py"

runtimes/go/plugin.yaml

@@ -0,0 +1,25 @@
+name: go
+# Go Programming Language Runtime
+# Provides the Go compiler and tools for building and running Go programs.
+description: Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
+default_version: 1.22.3
+download:
+  url_template: "https://go.dev/dl/go{{.Version}}.{{.OS}}-{{.Arch}}.tar.gz"
+  file_name_template: "go{{.Version}}.{{.OS}}-{{.Arch}}.tar.gz"
+  extension:
+    default: tar.gz
+    windows: zip
+  arch_mapping:
+    amd64: amd64
+    arm64: arm64
+    386: 386
+    arm: armv6l
+  os_mapping:
+    linux: linux
+    darwin: darwin
+    windows: windows
+binaries:
+  - name: go
+    path: bin/go
+  - name: gofmt
+    path: bin/gofmt

tools/licenseSimRunner.go

@@ -0,0 +1,53 @@
+package tools
+
+import (
+	"fmt"
+	"os"
+	"os/exec"
+	"path/filepath"
+	"strings"
+)
+
+// RunLicenseSim runs the license-sim tool (duncan.py) in the Python venv with the required environment variable.
+func RunLicenseSim(workDirectory string, binary string, files []string, outputFile string, outputFormat string) error {
+	// Determine the file to check and extension
+	var fileToCheck string
+	var ext string
+	if len(files) > 0 {
+		fileToCheck = files[0]
+		ext = filepath.Ext(fileToCheck)
+		if ext != "" {
+			ext = ext[1:] // remove dot
+		} else {
+			ext = "py" // default
+		}
+	} else {
+		return fmt.Errorf("No file specified for license-sim")
+	}
+
+	// Prepare command: ../../license-sim/venv/bin/python ../../license-sim/duncan.py search -f <file> -e <ext>
+	parts := strings.Split(binary, " ")
+	cmdArgs := append(parts[1:], "search", "-f", fileToCheck, "-e", ext)
+	cmd := exec.Command(parts[0], cmdArgs...)
+	cmd.Dir = workDirectory
+	cmd.Env = append(os.Environ(), "KMP_DUPLICATE_LIB_OK=TRUE")
+
+	// Output handling
+	if outputFile != "" {
+		outputWriter, err := os.Create(filepath.Clean(outputFile))
+		if err != nil {
+			return fmt.Errorf("failed to create output file: %w", err)
+		}
+		defer outputWriter.Close()
+		cmd.Stdout = outputWriter
+		cmd.Stderr = outputWriter
+	} else {
+		cmd.Stdout = os.Stdout
+		cmd.Stderr = os.Stderr
+	}
+
+	if err := cmd.Run(); err != nil {
+		return fmt.Errorf("failed to run license-sim: %w", err)
+	}
+	return nil
+}