fix lizard configuration parser

Author: franciscoovazevedo

codacy-client/client.go

@@ -113,17 +113,17 @@ func parsePatternConfigurations(response []byte) ([]domain.PatternConfiguration,
 		return nil, "", fmt.Errorf("failed to unmarshal response: %w", err)
 	}
 
-	var patterns []domain.PatternDefinition
-	if err := json.Unmarshal(objmap["data"], &patterns); err != nil {
+	var patternResponses []domain.PatternResponse
+	if err := json.Unmarshal(objmap["data"], &patternResponses); err != nil {
 		return nil, "", fmt.Errorf("failed to unmarshal patterns: %w", err)
 	}
 
-	patternConfigurations := make([]domain.PatternConfiguration, len(patterns))
-	for i, pattern := range patterns {
+	patternConfigurations := make([]domain.PatternConfiguration, len(patternResponses))
+	for i, patternResp := range patternResponses {
 		patternConfigurations[i] = domain.PatternConfiguration{
-			PatternDefinition: pattern,
-			Parameters:        pattern.Parameters,
-			Enabled:           pattern.Enabled,
+			PatternDefinition: patternResp.PatternDefinition,
+			Parameters:        patternResp.Parameters,
+			Enabled:           patternResp.Enabled,
 		}
 	}
 
@@ -149,7 +149,9 @@ func GetRepositoryToolPatterns(initFlags domain.InitFlags, toolUUID string) ([]d
 		initFlags.Organization,
 		initFlags.Repository,
 		toolUUID)
-	return getAllPages(baseURL, initFlags, parsePatternConfigurations)
+
+	result, err := getAllPages(baseURL, initFlags, parsePatternConfigurations)
+	return result, err
 }
 
 func GetRepositoryTools(initFlags domain.InitFlags) ([]domain.Tool, error) {

domain/patternConfiguration.go

@@ -25,3 +25,11 @@ type PatternConfiguration struct {
 	Parameters        []ParameterConfiguration
 	Enabled           bool `json:"enabled"`
 }
+
+// PatternResponse represents the structure of a pattern in the API response
+type PatternResponse struct {
+	PatternDefinition PatternDefinition        `json:"patternDefinition"`
+	Enabled           bool                     `json:"enabled"`
+	IsCustom          bool                     `json:"isCustom"`
+	Parameters        []ParameterConfiguration `json:"parameters"`
+}

tools/lizard/lizardConfigCreator.go

@@ -74,26 +74,23 @@ func getThresholdFromParams(params []domain.ParameterConfiguration) int {
 // getMetricTypeFromPatternId extracts the metric type from the pattern ID
 func getMetricTypeFromPatternId(patternID string) string {
 	// Pattern IDs are in the format "Lizard_metric-severity"
+
 	parts := strings.Split(patternID, "_")
 	if len(parts) != 2 {
 		fmt.Printf("Warning: Invalid pattern ID format: %s\n", patternID)
 		return ""
 	}
 
-	// Extract the metric type from the second part
-	// For patterns like "file-nloc-critical", we need to get "file-nloc"
+	// Extract the metric parts from the second part
 	metricParts := strings.Split(parts[1], "-")
 	if len(metricParts) < 2 {
 		fmt.Printf("Warning: Invalid metric format: %s\n", parts[1])
 		return ""
 	}
 
-	// Handle compound metric types
-	metricType := metricParts[0]
-	if len(metricParts) > 2 {
-		// For patterns like "file-nloc-critical", combine "file" and "nloc"
-		metricType = metricParts[0] + "-" + metricParts[1]
-	}
+	// The last part is always the severity (medium, critical, etc.)
+	// Everything before that is the metric type
+	metricType := strings.Join(metricParts[:len(metricParts)-1], "-")
 
 	// Validating that the metric type is one of the known types
 	switch metricType {