Skip to content

Commit 84386e8

Browse files
zhamborovazhamborova
committed
[PLUTO-1431] analyze revive with standard "./.." instead of "."
1 parent 616cea5 commit 84386e8

File tree

2 files changed

+38
-57
lines changed

2 files changed

+38
-57
lines changed

‎plugins/tools/revive/test/expected.sarif‎

Lines changed: 37 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,16 @@
1111
"uri": "bad.go"
1212
},
1313
"region": {
14-
"startColumn": 18,
15-
"startLine": 8
14+
"startColumn": 1,
15+
"startLine": 7
1616
}
1717
}
1818
}
1919
],
2020
"message": {
21-
"text": "parameter 'a' seems to be unused, consider removing or renaming it as _"
21+
"text": "comment on exported function BadFunction should be of the form \"BadFunction ...\""
2222
},
23-
"ruleId": "unused-parameter"
23+
"ruleId": "exported"
2424
},
2525
{
2626
"locations": [
@@ -30,16 +30,16 @@
3030
"uri": "bad.go"
3131
},
3232
"region": {
33-
"startColumn": 25,
34-
"startLine": 8
33+
"startColumn": 1,
34+
"startLine": 22
3535
}
3636
}
3737
}
3838
],
3939
"message": {
40-
"text": "parameter 'b' seems to be unused, consider removing or renaming it as _"
40+
"text": "comment on exported function LongLine should be of the form \"LongLine ...\""
4141
},
42-
"ruleId": "unused-parameter"
42+
"ruleId": "exported"
4343
},
4444
{
4545
"locations": [
@@ -49,16 +49,16 @@
4949
"uri": "bad.go"
5050
},
5151
"region": {
52-
"startColumn": 32,
53-
"startLine": 8
52+
"startColumn": 1,
53+
"startLine": 27
5454
}
5555
}
5656
}
5757
],
5858
"message": {
59-
"text": "parameter 'c' seems to be unused, consider removing or renaming it as _"
59+
"text": "comment on exported function NakedReturn should be of the form \"NakedReturn ...\""
6060
},
61-
"ruleId": "unused-parameter"
61+
"ruleId": "exported"
6262
},
6363
{
6464
"locations": [
@@ -68,16 +68,16 @@
6868
"uri": "bad.go"
6969
},
7070
"region": {
71-
"startColumn": 39,
72-
"startLine": 8
71+
"startColumn": 1,
72+
"startLine": 1
7373
}
7474
}
7575
}
7676
],
7777
"message": {
78-
"text": "parameter 'd' seems to be unused, consider removing or renaming it as _"
78+
"text": "should have a package comment"
7979
},
80-
"ruleId": "unused-parameter"
80+
"ruleId": "package-comments"
8181
},
8282
{
8383
"locations": [
@@ -87,14 +87,14 @@
8787
"uri": "bad.go"
8888
},
8989
"region": {
90-
"startColumn": 46,
90+
"startColumn": 18,
9191
"startLine": 8
9292
}
9393
}
9494
}
9595
],
9696
"message": {
97-
"text": "parameter 'e' seems to be unused, consider removing or renaming it as _"
97+
"text": "parameter 'a' seems to be unused, consider removing or renaming it as _"
9898
},
9999
"ruleId": "unused-parameter"
100100
},
@@ -106,14 +106,14 @@
106106
"uri": "bad.go"
107107
},
108108
"region": {
109-
"startColumn": 17,
110-
"startLine": 18
109+
"startColumn": 25,
110+
"startLine": 8
111111
}
112112
}
113113
}
114114
],
115115
"message": {
116-
"text": "parameter 'unused' seems to be unused, consider removing or renaming it as _"
116+
"text": "parameter 'b' seems to be unused, consider removing or renaming it as _"
117117
},
118118
"ruleId": "unused-parameter"
119119
},
@@ -125,35 +125,16 @@
125125
"uri": "bad.go"
126126
},
127127
"region": {
128-
"startColumn": 1,
129-
"startLine": 7
130-
}
131-
}
132-
}
133-
],
134-
"message": {
135-
"text": "comment on exported function BadFunction should be of the form \"BadFunction ...\""
136-
},
137-
"ruleId": "exported"
138-
},
139-
{
140-
"locations": [
141-
{
142-
"physicalLocation": {
143-
"artifactLocation": {
144-
"uri": "bad.go"
145-
},
146-
"region": {
147-
"startColumn": 1,
148-
"startLine": 22
128+
"startColumn": 32,
129+
"startLine": 8
149130
}
150131
}
151132
}
152133
],
153134
"message": {
154-
"text": "comment on exported function LongLine should be of the form \"LongLine ...\""
135+
"text": "parameter 'c' seems to be unused, consider removing or renaming it as _"
155136
},
156-
"ruleId": "exported"
137+
"ruleId": "unused-parameter"
157138
},
158139
{
159140
"locations": [
@@ -163,16 +144,16 @@
163144
"uri": "bad.go"
164145
},
165146
"region": {
166-
"startColumn": 1,
167-
"startLine": 27
147+
"startColumn": 39,
148+
"startLine": 8
168149
}
169150
}
170151
}
171152
],
172153
"message": {
173-
"text": "comment on exported function NakedReturn should be of the form \"NakedReturn ...\""
154+
"text": "parameter 'd' seems to be unused, consider removing or renaming it as _"
174155
},
175-
"ruleId": "exported"
156+
"ruleId": "unused-parameter"
176157
},
177158
{
178159
"locations": [
@@ -182,16 +163,16 @@
182163
"uri": "bad.go"
183164
},
184165
"region": {
185-
"startColumn": 10,
186-
"startLine": 9
166+
"startColumn": 46,
167+
"startLine": 8
187168
}
188169
}
189170
}
190171
],
191172
"message": {
192-
"text": "should omit type int from declaration of var foo; it will be inferred from the right-hand side"
173+
"text": "parameter 'e' seems to be unused, consider removing or renaming it as _"
193174
},
194-
"ruleId": "var-declaration"
175+
"ruleId": "unused-parameter"
195176
},
196177
{
197178
"locations": [
@@ -201,16 +182,16 @@
201182
"uri": "bad.go"
202183
},
203184
"region": {
204-
"startColumn": 1,
205-
"startLine": 1
185+
"startColumn": 17,
186+
"startLine": 18
206187
}
207188
}
208189
}
209190
],
210191
"message": {
211-
"text": "should have a package comment"
192+
"text": "parameter 'unused' seems to be unused, consider removing or renaming it as _"
212193
},
213-
"ruleId": "package-comments"
194+
"ruleId": "unused-parameter"
214195
}
215196
],
216197
"tool": {

‎tools/revive/reviveRunner.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ func RunRevive(workDirectory string, binary string, files []string, outputFile s
2828
if len(files) > 0 {
2929
cmdArgs = append(cmdArgs, files...)
3030
} else {
31-
cmdArgs = append(cmdArgs, ".")
31+
cmdArgs = append(cmdArgs, "./...")
3232
}
3333

3434
cmd := exec.Command(binary, cmdArgs...)

0 commit comments

Comments
 (0)