fix: Fix registry option for ESLint

Author: machadoit

cmd/install.go

@@ -20,20 +20,20 @@ var installCmd = &cobra.Command{
 	Long:  "Installs all runtimes and tools specified in the project's config-file file.",
 	Run: func(cmd *cobra.Command, args []string) {
 		installRuntimes(&cfg.Config)
-		installTools(&cfg.Config)
+		installTools(&cfg.Config, registry)
 	},
 }
 
 func installRuntimes(config *cfg.ConfigType) {
-	err := cfg.InstallRuntimes()
+	err := cfg.InstallRuntimes(config)
 	if err != nil {
 		log.Fatal(err)
 	}
 }
 
-func installTools(config *cfg.ConfigType) {
+func installTools(config *cfg.ConfigType, registry string) {
 	// Use the new tools-installer instead of manual installation
-	err := cfg.InstallTools()
+	err := cfg.InstallTools(config, registry)
 	if err != nil {
 		log.Fatal(err)
 	}

config/runtimes-installer.go

@@ -11,8 +11,8 @@ import (
 )
 
 // InstallRuntimes installs all runtimes defined in the configuration
-func InstallRuntimes() error {
-	for name, runtimeInfo := range Config.Runtimes() {
+func InstallRuntimes(config *ConfigType) error {
+	for name, runtimeInfo := range config.Runtimes() {
 		err := InstallRuntime(name, runtimeInfo)
 		if err != nil {
 			return fmt.Errorf("failed to install runtime %s: %w", name, err)

config/tools-installer.go

@@ -14,9 +14,9 @@ import (
 )
 
 // InstallTools installs all tools defined in the configuration
-func InstallTools() error {
-	for name, toolInfo := range Config.Tools() {
-		err := InstallTool(name, toolInfo)
+func InstallTools(config *ConfigType, registry string) error {
+	for name, toolInfo := range config.Tools() {
+		err := InstallTool(name, toolInfo, registry)
 		if err != nil {
 			return fmt.Errorf("failed to install tool %s: %w", name, err)
 		}
@@ -25,7 +25,7 @@ func InstallTools() error {
 }
 
 // InstallTool installs a specific tool
-func InstallTool(name string, toolInfo *plugins.ToolInfo) error {
+func InstallTool(name string, toolInfo *plugins.ToolInfo, registry string) error {
 	// Check if the tool is already installed
 	if isToolInstalled(toolInfo) {
 		fmt.Printf("Tool %s v%s is already installed\n", name, toolInfo.Version)
@@ -50,10 +50,10 @@ func InstallTool(name string, toolInfo *plugins.ToolInfo) error {
 	}
 
 	// Handle other runtime-based tools
-	return installRuntimeTool(name, toolInfo)
+	return installRuntimeTool(name, toolInfo, registry)
 }
 
-func installRuntimeTool(name string, toolInfo *plugins.ToolInfo) error {
+func installRuntimeTool(name string, toolInfo *plugins.ToolInfo, registry string) error {
 	// Get the runtime for this tool
 	runtimeInfo, ok := Config.Runtimes()[toolInfo.Runtime]
 	if !ok {
@@ -65,7 +65,7 @@ func installRuntimeTool(name string, toolInfo *plugins.ToolInfo) error {
 		"InstallDir":  toolInfo.InstallDir,
 		"PackageName": toolInfo.Name,
 		"Version":     toolInfo.Version,
-		"Registry":    "", // TODO: Get registry from config
+		"Registry":    registry,
 	}
 
 	// Get package manager binary based on the tool configuration
@@ -76,12 +76,14 @@ func installRuntimeTool(name string, toolInfo *plugins.ToolInfo) error {
 	}
 
 	// Set registry if provided
-	if toolInfo.RegistryCommand != "" {
+	if registry != "" {
 		regCmd, err := executeToolTemplate(toolInfo.RegistryCommand, templateData)
 		if err != nil {
 			return fmt.Errorf("failed to prepare registry command: %w", err)
 		}
 
+		log.Printf("Setting registry...\n %s %s\n", packageManagerBinary, regCmd)
+
 		if regCmd != "" {
 			registryCmd := exec.Command(packageManagerBinary, strings.Split(regCmd, " ")...)
 			if output, err := registryCmd.CombinedOutput(); err != nil {

plugins/tools/eslint/plugin.yaml

@@ -6,7 +6,7 @@ runtime_binaries:
   execution: node
 installation:
   command: "install --prefix {{.InstallDir}} {{.PackageName}}@{{.Version}} @microsoft/eslint-formatter-sarif"
-  registry_template: "{{if .Registry}}config set registry {{.Registry}}{{end}}"
+  registry_template: "config set registry {{.Registry}}"
 binaries:
   - name: eslint
     path: "node_modules/.bin/eslint"